Skip to content

Commit b546521

Browse files
committed
test: fix tests to work w/ cli
1 parent 6f62389 commit b546521

File tree

2 files changed

+18
-9
lines changed

2 files changed

+18
-9
lines changed

tests/integration/test_pending_cli.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ def test_propose(runner, cli, safe_account, receiver, chain):
1313
cmd = (
1414
"pending",
1515
"propose",
16+
"--safe",
17+
safe_account.alias,
1618
"--to",
1719
receiver.address,
1820
"--value",
@@ -25,13 +27,8 @@ def test_propose(runner, cli, safe_account, receiver, chain):
2527
# so it prompts the user.
2628
sender_input = f"{safe_account.alias}\n"
2729

28-
result = runner.invoke(cli, cmd, catch_exceptions=False, input=sender_input)
30+
result = runner.invoke(cli, cmd, input=sender_input)
2931
assert result.exit_code == 0
30-
assert "Proposed transaction" in result.output
31-
safe_tx_hash = result.output.split("Proposed transaction '")[-1].split("'")[0].strip()
32-
33-
# Verify the transaction is in the service.
34-
assert safe_tx_hash in safe_account.client.transactions
3532

3633
# The nonce is the same because we did not execute.
3734
assert safe_account.next_nonce == nonce_at_start
@@ -45,6 +42,8 @@ def test_propose_with_sender(runner, cli, safe_account, receiver, chain, foundry
4542
cmd = (
4643
"pending",
4744
"propose",
45+
"--safe",
46+
safe_account.alias,
4847
"--to",
4948
receiver.address,
5049
"--value",
@@ -69,6 +68,8 @@ def test_propose_with_execute(runner, cli, safe_account, receiver, chain):
6968
cmd = (
7069
"pending",
7170
"propose",
71+
"--safe",
72+
safe_account.alias,
7273
"--to",
7374
receiver.address,
7475
"--value",

tests/integration/test_safe_mgmt_cli.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,17 +44,25 @@ def test_add_safe(runner, cli, safe, chain, safe_container):
4444
input="y\n",
4545
)
4646
assert result.exit_code == 0, result.output
47-
assert "SUCCESS" in result.output, result.output
47+
48+
result = runner.invoke(cli, "list")
49+
assert safe.address in result.output, result.output
4850
safe_container.delete_account(safe.alias)
4951

5052

5153
def test_remove_safe(runner, cli, safe_account):
54+
safe_address = safe_account.address
5255
result = runner.invoke(cli, ("remove", safe_account.alias), catch_exceptions=False, input="y\n")
5356
assert result.exit_code == 0, result.output
54-
assert "SUCCESS" in result.output, result.output
57+
58+
result = runner.invoke(cli, "list")
59+
assert safe_address not in result.output, result.output
5560

5661

5762
def test_remove_safe_skip_confirmation(runner, cli, safe_account):
63+
safe_address = safe_account.address
5864
result = runner.invoke(cli, ("remove", safe_account.alias, "--yes"), catch_exceptions=False)
5965
assert result.exit_code == 0, result.output
60-
assert "SUCCESS" in result.output, result.output
66+
67+
result = runner.invoke(cli, "list")
68+
assert safe_address not in result.output, result.output

0 commit comments

Comments
 (0)