Return empty array when no items to pop

fgiannar · fgiannar · commit 0419fff7208b · 2026-01-23T07:52:03.000+02:00
diff --git a/projects/packages/sync/src/class-queue.php b/projects/packages/sync/src/class-queue.php
@@ -271,7 +271,7 @@ public function pop( $limit ) {
 		$items = $this->fetch_items( $limit );
 
 		if ( ! $items ) {
-			return;
+			return array();
 		}
 
 		$ids = $this->get_ids( $items );
@@ -292,7 +292,7 @@ public function pop_newest( $limit ) {
 		$items = $this->fetch_items( $limit, 'DESC' );
 
 		if ( ! $items ) {
-			return;
+			return array();
 		}
 
 		$ids = $this->get_ids( $items );

Original file line number	Diff line number	Diff line change
`@@ -271,7 +271,7 @@ public function pop( $limit ) {`
`271`	`271`	`$items = $this->fetch_items( $limit );`
`272`	`272`
`273`	`273`	`if ( ! $items ) {`
`274`		`- return;`
	`274`	`+ return array();`
`275`	`275`	`}`
`276`	`276`
`277`	`277`	`$ids = $this->get_ids( $items );`
`@@ -292,7 +292,7 @@ public function pop_newest( $limit ) {`
`292`	`292`	`$items = $this->fetch_items( $limit, 'DESC' );`
`293`	`293`
`294`	`294`	`if ( ! $items ) {`
`295`		`- return;`
	`295`	`+ return array();`
`296`	`296`	`}`
`297`	`297`
`298`	`298`	`$ids = $this->get_ids( $items );`