[BUG] values.yaml file provides no default for datadog.autoscaling.workload.enabled

[mrbobfrog]

Agent version

3.158.3

Bug Report

When test rendering the kubernetes manifests for datadog chart version 3.158.3, we get the following error

dependencies.go:64: Warning: Condition path 'datadog.autoscaling.workload.enabled' for chart datadog-crds returned non-bool value

Reproduction Steps

1. render the manifests

   helm template datadog/datadog --version 3.158.3 --include-crds > /dev/null
   dependencies.go:64: Warning: Condition path 'datadog.autoscaling.workload.enabled' for chart datadog-crds returned non-bool value
   

Agent configuration

No response

Operating System

Linux/Docker

Other environment details

No response

[mrbobfrog]

Easy, workaround to provide the default in one's local values.yaml file, though it should not be necessary

datadog:
  autoscaling:            # values line 1312
    workload:
      enabled: false

[celenechang]

Hi @mrbobfrog , thanks for the issue. In our testing, this warning didn't produce any negative impact; did you experience otherwise?

The default value was made blank in this PR, to address a regression described here. Apologies for the unintended noise it causes; hope the additional context helps.

[mrbobfrog]

No negative effect other than confusion. It's curious that the behavior of "false" is different from empty -- does that mean we're using a boolean to describe three different outcomes:

1. true: enable auto-scaling and include the CRD
2. false: disable auto-scaling and not include the CRD
3. empty: disable auto-scaling and include the CRD
   ?

Does it make more logical sense to have CRD inclusion either way or to not include the related CRD as a separate option?

We can close this issue, as it is a known, albeit IMHO inelegant, workaround