libriichi: fix cargo clippy issues

Author: Equim-chan

libriichi/src/algo/sp/state.rs

@@ -54,7 +54,7 @@ impl From<InitState> for State {
 }
 
 impl State {
-    pub(super) fn discard(&mut self, tile: Tile) {
+    pub(super) const fn discard(&mut self, tile: Tile) {
         self.tehai[tile.deaka().as_usize()] -= 1;
         match tile.as_u8() {
             tu8!(5mr) => self.akas_in_hand[0] = false,
@@ -64,7 +64,7 @@ impl State {
         }
     }
 
-    pub(super) fn undo_discard(&mut self, tile: Tile) {
+    pub(super) const fn undo_discard(&mut self, tile: Tile) {
         self.tehai[tile.deaka().as_usize()] += 1;
         match tile.as_u8() {
             tu8!(5mr) => self.akas_in_hand[0] = true,
@@ -74,7 +74,7 @@ impl State {
         }
     }
 
-    pub(super) fn deal(&mut self, tile: Tile) {
+    pub(super) const fn deal(&mut self, tile: Tile) {
         self.tiles_in_wall[tile.deaka().as_usize()] -= 1;
         match tile.as_u8() {
             tu8!(5mr) => self.akas_in_wall[0] = false,
@@ -85,7 +85,7 @@ impl State {
         self.undo_discard(tile);
     }
 
-    pub(super) fn undo_deal(&mut self, tile: Tile) {
+    pub(super) const fn undo_deal(&mut self, tile: Tile) {
         self.discard(tile);
         self.tiles_in_wall[tile.deaka().as_usize()] += 1;
         match tile.as_u8() {

libriichi/src/arena/board.rs

@@ -293,7 +293,7 @@ impl BoardState {
         // no need to broadcast
     }
 
-    fn update_nagashi_mangan_and_four_wind(&mut self, ev: &Event) {
+    const fn update_nagashi_mangan_and_four_wind(&mut self, ev: &Event) {
         match *ev {
             Event::Dahai { actor, pai, .. } if !pai.is_yaokyuu() => {
                 self.can_nagashi_mangan[actor as usize] = false;

libriichi/src/arena/one_vs_three.rs

@@ -138,7 +138,7 @@ impl OneVsThree {
         );
 
         let seeds: Vec<_> = (seed_start.0..seed_start.0 + seed_count)
-            .flat_map(|seed| iter::repeat((seed, seed_start.1)).take(4))
+            .flat_map(|seed| iter::repeat_n((seed, seed_start.1), 4))
             .collect();
 
         let challenger_player_ids: Vec<_> = (0..4).cycle().take(seed_count as usize * 4).collect();

libriichi/src/arena/two_vs_two.rs

@@ -135,7 +135,7 @@ impl TwoVsTwo {
         );
 
         let seeds: Vec<_> = (seed_start.0..seed_start.0 + seed_count)
-            .flat_map(|seed| iter::repeat((seed, seed_start.1)).take(2))
+            .flat_map(|seed| iter::repeat_n((seed, seed_start.1), 2))
             .collect();
 
         let challenger_player_ids_per_seed = [

libriichi/src/array.rs

@@ -18,7 +18,7 @@ where
     }
 
     #[inline]
-    pub fn rows(&self) -> usize {
+    pub const fn rows(&self) -> usize {
         self.arr.len() / COLS
     }
 

libriichi/src/dataset/gameplay.rs

@@ -379,7 +379,7 @@ impl Gameplay {
                     // Check if the POV is one of those who made Hora.
                     for ev in &wnd[1..] {
                         match *ev {
-                            Event::EndKyoku { .. } => break,
+                            Event::EndKyoku => break,
                             Event::Hora { actor, .. } if actor == self.player_id => {
                                 ret = Some(43);
                                 break;

libriichi/src/dataset/invisible.rs

@@ -116,7 +116,7 @@ impl Invisible {
                         .into_iter()
                         .enumerate()
                         .filter(|&(_, count)| count > 0)
-                        .flat_map(|(tid, count)| iter::repeat(must_tile!(tid)).take(count as usize))
+                        .flat_map(|(tid, count)| iter::repeat_n(must_tile!(tid), count as usize))
                         .collect();
                     filler.shuffle(&mut rng());
 

libriichi/src/mjai/bot.rs

@@ -54,7 +54,7 @@ impl Bot {
                 self.log.clear();
                 self.agent.end_kyoku(0)?;
             }
-            Event::EndGame { .. } => {
+            Event::EndGame => {
                 self.agent.end_game(0, &Default::default())?;
             }
             _ => {

libriichi/src/mjai/event.rs

@@ -185,7 +185,7 @@ impl Event {
     }
 
     pub fn augment(&mut self) {
-        fn swap_tile(t: &mut Tile) {
+        const fn swap_tile(t: &mut Tile) {
             *t = t.augment();
         }
 

libriichi/src/state/update.rs

@@ -662,7 +662,7 @@ impl PlayerState {
         Ok(())
     }
 
-    fn reach(&mut self, actor: u8) {
+    const fn reach(&mut self, actor: u8) {
         let actor_rel = self.rel(actor);
         self.riichi_declared[actor_rel] = true;
         if actor_rel == 0 {
@@ -952,7 +952,7 @@ impl PlayerState {
         }
     }
 
-    pub(super) fn update_doras_owned(&mut self, actor_rel: usize, tile: Tile) {
+    pub(super) const fn update_doras_owned(&mut self, actor_rel: usize, tile: Tile) {
         self.doras_owned[actor_rel] += self.dora_factor[tile.deaka().as_usize()];
         if tile.is_aka() {
             self.doras_owned[actor_rel] += 1;