Skip to content

Commit 1978970

Browse files
committed
Sort projects alphabetically in configuration.json
1 parent fd99102 commit 1978970

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/Configuration/ConfigurationWriter.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ public function __construct(
2929
*/
3030
public function write(array $projects): void
3131
{
32+
usort($projects, static fn(Project $a, Project $b): int => $a->identifier <=> $b->identifier);
3233
$projectsAsArray = [];
3334
foreach ($projects as $project) {
3435
if (in_array($project->identifier, $this->skippedProjects, true)) {

tests/Configuration/ConfigurationWriterTest.php

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
namespace FriendsOfTYPO3\CrowdinBase\Tests\Configuration;
77

8-
use _PHPStan_6597ef616\Nette\Utils\JsonException;
98
use FriendsOfTYPO3\CrowdinBase\Configuration\Exception\ConfigurationFileWriteException;
109
use FriendsOfTYPO3\CrowdinBase\Configuration\ConfigurationReader;
1110
use FriendsOfTYPO3\CrowdinBase\Configuration\ConfigurationWriter;
@@ -35,15 +34,15 @@ public function writeCreatesConfigurationFileCorrectly(): void
3534

3635
self::assertCount(2, $actual);
3736

38-
self::assertSame(1, $actual[0]->id);
39-
self::assertSame('typo3-extension-some-identifier', $actual[0]->identifier);
40-
self::assertSame('news', $actual[0]->name);
41-
self::assertSame(['de'], $actual[0]->languages);
42-
43-
self::assertSame(2, $actual[1]->id);
44-
self::assertSame('typo3-extension-another-identifier', $actual[1]->identifier);
45-
self::assertSame('tt_address', $actual[1]->name);
46-
self::assertSame(['fr', 'it'], $actual[1]->languages);
37+
self::assertSame(2, $actual[0]->id);
38+
self::assertSame('typo3-extension-another-identifier', $actual[0]->identifier);
39+
self::assertSame('tt_address', $actual[0]->name);
40+
self::assertSame(['fr', 'it'], $actual[0]->languages);
41+
42+
self::assertSame(1, $actual[1]->id);
43+
self::assertSame('typo3-extension-some-identifier', $actual[1]->identifier);
44+
self::assertSame('news', $actual[1]->name);
45+
self::assertSame(['de'], $actual[1]->languages);
4746

4847
unlink($configurationFile);
4948
}

0 commit comments

Comments
 (0)