Adding ToolVersion to Dialogflow CX by shang-jason · Pull Request #15945 · GoogleCloudPlatform/magic-modules

shang-jason · 2025-12-12T20:30:27Z

`google_dialogflow_cx_tool_version`

github-actions · 2025-12-12T20:31:34Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-12-12T20:50:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 3152 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 3838 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 988 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 593 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_cx_tool_version (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_cx_tool_version" "primary" {
  tool {
    connector_spec {
      end_user_auth_config {
        oauth2_auth_code_config {
          oauth_token = # value needed
        }
        oauth2_jwt_bearer_config {
          client_key = # value needed
          issuer     = # value needed
          subject    = # value needed
        }
      }
    }
    open_api_spec {
      authentication {
        api_key_config {
          api_key                    = # value needed
          key_name                   = # value needed
          request_location           = # value needed
          secret_version_for_api_key = # value needed
        }
        bearer_token_config {
          secret_version_for_token = # value needed
          token                    = # value needed
        }
        service_agent_auth_config {
          service_agent_auth = # value needed
        }
      }
    }
  }
}

modular-magician · 2025-12-12T20:54:55Z

Tests analytics

Total tests: 50
Passed tests: 44
Skipped tests: 0
Affected tests: 6

Click here to see the affected service packages

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2025-12-12T20:58:26Z

🟢 Tests passed during RECORDING mode:
TestAccDialogflowCXToolVersion_dialogflowcxToolVersionConnectorExample [Debug log]
TestAccDialogflowCXToolVersion_dialogflowcxToolVersionDataStoreExample [Debug log]
TestAccDialogflowCXToolVersion_dialogflowcxToolVersionFunctionExample [Debug log]
TestAccDialogflowCXToolVersion_dialogflowcxToolVersionOpenApiExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

mmv1/products/dialogflowcx/ToolVersion.yaml

slevenick · 2025-12-12T22:24:38Z

mmv1/templates/terraform/examples/dialogflowcx_tool_version_connector.tf.tmpl

+
+resource "google_integration_connectors_connection" "integration_connector" {
+  provider = google-beta
+  name     = "terraform-df-cx-tool-connection"


This should be a variable set through the template like {{index $.Vars "agent_name"}} up above. This lets us add random suffixes to these to ensure they can be run in parallel.

Same for the dataset & table ids below

github-actions · 2025-12-26T09:44:16Z

@shang-jason, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

modular-magician · 2026-01-07T20:09:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 3152 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 3838 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 988 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 593 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_cx_tool_version (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_cx_tool_version" "primary" {
  tool {
    connector_spec {
      end_user_auth_config {
        oauth2_auth_code_config {
          oauth_token = # value needed
        }
        oauth2_jwt_bearer_config {
          client_key = # value needed
          issuer     = # value needed
          subject    = # value needed
        }
      }
    }
    open_api_spec {
      authentication {
        api_key_config {
          api_key                    = # value needed
          key_name                   = # value needed
          request_location           = # value needed
          secret_version_for_api_key = # value needed
        }
        bearer_token_config {
          secret_version_for_token = # value needed
          token                    = # value needed
        }
        service_agent_auth_config {
          service_agent_auth = # value needed
        }
      }
    }
  }
}

modular-magician · 2026-01-07T20:17:05Z

Tests analytics

Total tests: 50
Passed tests: 48
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-07T20:17:32Z

🔴 Tests failed during RECORDING mode:
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-01-07T20:32:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 3152 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 3838 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 988 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 593 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_cx_tool_version (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_cx_tool_version" "primary" {
  tool {
    connector_spec {
      end_user_auth_config {
        oauth2_auth_code_config {
          oauth_token = # value needed
        }
        oauth2_jwt_bearer_config {
          client_key = # value needed
          issuer     = # value needed
          subject    = # value needed
        }
      }
    }
    open_api_spec {
      authentication {
        api_key_config {
          api_key                    = # value needed
          key_name                   = # value needed
          request_location           = # value needed
          secret_version_for_api_key = # value needed
        }
        bearer_token_config {
          secret_version_for_token = # value needed
          token                    = # value needed
        }
        service_agent_auth_config {
          service_agent_auth = # value needed
        }
      }
    }
  }
}

modular-magician · 2026-01-07T20:34:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 3152 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 3838 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 988 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 593 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_cx_tool_version (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_cx_tool_version" "primary" {
  tool {
    connector_spec {
      end_user_auth_config {
        oauth2_auth_code_config {
          oauth_token = # value needed
        }
        oauth2_jwt_bearer_config {
          client_key = # value needed
          issuer     = # value needed
          subject    = # value needed
        }
      }
    }
    open_api_spec {
      authentication {
        api_key_config {
          api_key                    = # value needed
          key_name                   = # value needed
          request_location           = # value needed
          secret_version_for_api_key = # value needed
        }
        bearer_token_config {
          secret_version_for_token = # value needed
          token                    = # value needed
        }
        service_agent_auth_config {
          service_agent_auth = # value needed
        }
      }
    }
  }
}

modular-magician · 2026-01-07T20:37:13Z

Tests analytics

Total tests: 50
Passed tests: 44
Skipped tests: 0
Affected tests: 6

Click here to see the affected service packages

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-07T20:38:09Z

🟢 Tests passed during RECORDING mode:
TestAccDialogflowCXToolVersion_dialogflowcxToolVersionDataStoreExample [Debug log]
TestAccDialogflowCXToolVersion_dialogflowcxToolVersionFunctionExample [Debug log]
TestAccDialogflowCXToolVersion_dialogflowcxToolVersionOpenApiExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]
TestAccDialogflowCXToolVersion_dialogflowcxToolVersionConnectorExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-01-07T20:40:13Z

Tests analytics

Total tests: 50
Passed tests: 47
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-07T20:40:40Z

🔴 Tests failed during RECORDING mode:
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]
TestAccDialogflowCXToolVersion_dialogflowcxToolVersionConnectorExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-01-07T21:07:19Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 3152 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 3838 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 988 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 593 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_cx_tool_version (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_cx_tool_version" "primary" {
  tool {
    connector_spec {
      end_user_auth_config {
        oauth2_auth_code_config {
          oauth_token = # value needed
        }
        oauth2_jwt_bearer_config {
          client_key = # value needed
          issuer     = # value needed
          subject    = # value needed
        }
      }
    }
    open_api_spec {
      authentication {
        api_key_config {
          api_key                    = # value needed
          key_name                   = # value needed
          request_location           = # value needed
          secret_version_for_api_key = # value needed
        }
        bearer_token_config {
          secret_version_for_token = # value needed
          token                    = # value needed
        }
        service_agent_auth_config {
          service_agent_auth = # value needed
        }
      }
    }
  }
}

modular-magician · 2026-01-07T21:12:40Z

Tests analytics

Total tests: 50
Passed tests: 47
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-01-07T21:15:36Z

🟢 Tests passed during RECORDING mode:
TestAccDialogflowCXToolVersion_dialogflowcxToolVersionConnectorExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDialogflowCXTestCase_dialogflowcxTestCaseFullExample [Error message] [Debug log]
TestAccDialogflowCXTestCase_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2026-01-12T09:49:57Z

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions · 2026-01-14T09:47:59Z

@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

slevenick

Generally this looks good, one question about the parent field though, I think it should be required

slevenick · 2026-01-16T19:29:01Z

mmv1/products/dialogflowcx/ToolVersion.yaml

+      The tool to create a Version for.
+      Format: projects/<Project ID>/locations/<Location ID>/agents/<Agent ID>/tools/<Tool ID>.
+    url_param_only: true
+    immutable: true


required: true also?

modular-magician · 2026-01-16T20:33:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 3152 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 3838 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 988 insertions(+))
Open in Cloud Shell: Diff ( 12 files changed, 593 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dialogflow_cx_tool_version (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dialogflow_cx_tool_version" "primary" {
  tool {
    connector_spec {
      end_user_auth_config {
        oauth2_auth_code_config {
          oauth_token = # value needed
        }
        oauth2_jwt_bearer_config {
          client_key = # value needed
          issuer     = # value needed
          subject    = # value needed
        }
      }
    }
    open_api_spec {
      authentication {
        api_key_config {
          api_key                    = # value needed
          key_name                   = # value needed
          request_location           = # value needed
          secret_version_for_api_key = # value needed
        }
        bearer_token_config {
          secret_version_for_token = # value needed
          token                    = # value needed
        }
        service_agent_auth_config {
          service_agent_auth = # value needed
        }
      }
    }
  }
}

modular-magician · 2026-01-16T20:40:56Z

Tests analytics

Total tests: 52
Passed tests: 50
Skipped tests: 2
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

Adding toolVersion to dialogflow cx

bf79a29

github-actions bot requested a review from slevenick December 12, 2025 20:31

modular-magician added the service/dialogflow-cx label Dec 12, 2025

slevenick requested changes Dec 12, 2025

View reviewed changes

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 7, 2026

github-actions bot requested a review from slevenick January 7, 2026 19:39

shang-jason marked this pull request as draft January 7, 2026 19:40

shang-jason force-pushed the df-toolVersion branch from d09102e to bf79a29 Compare January 7, 2026 19:56

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 7, 2026

shang-jason added 2 commits January 7, 2026 15:19

Merge branch 'GoogleCloudPlatform:main' into df-toolVersion

5ae94d3

Add variables for names and id

20b2b96

Changed name to valid value

dd83635

shang-jason marked this pull request as ready for review January 7, 2026 21:20

slevenick reviewed Jan 16, 2026

View reviewed changes

Setting parent as required

6598947

github-actions bot requested a review from slevenick January 16, 2026 20:22

slevenick approved these changes Jan 16, 2026

View reviewed changes

slevenick added this pull request to the merge queue Jan 16, 2026

Merged via the queue into GoogleCloudPlatform:main with commit 0e268be Jan 16, 2026
25 of 26 checks passed

SirGitsalot pushed a commit that referenced this pull request Jan 28, 2026

Adding ToolVersion to Dialogflow CX (#15945)

539e291

wuchris-g pushed a commit to wuchris-g/magic-modules that referenced this pull request Feb 5, 2026

Adding ToolVersion to Dialogflow CX (GoogleCloudPlatform#15945)

b23f59f

Conversation

shang-jason commented Dec 12, 2025

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

modular-magician commented Dec 12, 2025

Diff report

Missing test report

Uh oh!

modular-magician commented Dec 12, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented Dec 12, 2025

Uh oh!

Uh oh!

slevenick Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

shang-jason Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

modular-magician commented Jan 7, 2026

Diff report

Missing test report

Uh oh!

modular-magician commented Jan 7, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 7, 2026

Uh oh!

modular-magician commented Jan 7, 2026

Diff report

Missing test report

Uh oh!

modular-magician commented Jan 7, 2026

Diff report

Missing test report

Uh oh!

modular-magician commented Jan 7, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 7, 2026

Uh oh!

modular-magician commented Jan 7, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 7, 2026

Uh oh!

modular-magician commented Jan 7, 2026

Diff report

Missing test report

Uh oh!

modular-magician commented Jan 7, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 12, 2026

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

slevenick left a comment

Choose a reason for hiding this comment

Uh oh!

slevenick Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

shang-jason Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Jan 16, 2026

Diff report

Missing test report