Define and document IDs for limited-time Trusts (Cornelia & Matsui-P)

[eyes-and-brain]

I would like to suggest defining and documenting the IDs for Cornelia and Matsui-P in the source code and SQL files.

While these were limited-time Trusts in retail, having their IDs officially reserved in the project helps maintain consistency and prevents ID conflicts when server administrators want to implement them manually. Even if they are commented out by default, having the correct IDs documented is highly beneficial for the community.

Proposed IDs:

• Magic Enum: CORNELIA = 1002, MATSUI_P = 1003
• Mob Pools: 6002, 6003
• Spell List: 1002, 1003

Could we consider adding these definitions to the repository, perhaps with comments indicating their limited-time nature in retail?

[zach2good]

We could add these back, we've previously had these as populated entries, but the client isn't turning them on/off every time they're swapped - the client is fully removing/replacing the spell information for that trust, it's hard to justify how we keep it: If we don't update every patch cycle, the spell will cast the wrong trust.

Here's some of ths historic information I could dig up from old PRs:

-----------------------------------
-- Trust: Matsui-P
-----------------------------------
require("scripts/globals/gambits")
require("scripts/globals/magic")
require("scripts/globals/trust")
-----------------------------------
local spell_object = {}

local message_page_offset = 121

spell_object.onMagicCastingCheck = function(caster, target, spell)
    return xi.trust.canCast(caster, spell)
end

spell_object.onSpellCast = function(caster, target, spell)
    return xi.trust.spawn(caster, spell)
end

spell_object.onMobSpawn = function(mob)
    xi.trust.message(mob, message_page_offset, xi.trust.message_offset.SPAWN)

    -- "Prefers to open skillchains. Will remember the last weapon skill used by the party leader
    -- and will open the highest-tier skillchain possible. Will not open skillchains for other
    -- trusts in the party."
    mob:setTrustTPSkillSettings(ai.tp.OPENER, ai.s.SPECIAL_AYAME)
end

spell_object.onMobDespawn = function(mob)
    xi.trust.message(mob, message_page_offset, xi.trust.message_offset.DESPAWN)
end

spell_object.onMobDeath = function(mob)
    xi.trust.message(mob, message_page_offset, xi.trust.message_offset.DEATH)
end

return spell_object

-- INSERT INTO `mob_pools` VALUES (6003,'matsui-p','Matsui-P',153,0x0000310C00000000000000000000000000000000,13,4,9,190,60,0,0,0,0,0,0,32,0,3,0,0,435,0,0,1148);

-- INSERT INTO `spell_list` VALUES (1003,'matsui-p',0x01010101010101010101010101010101010101010101,8,0,7,0,1,0,0,3000,24000,0,0,939,1500,0,0,1.00,0,0,0,0,NULL);

This destructive shifting pattern is why I made this module: https://github.com/LandSandBoat/server/blob/base/modules/custom/lua/replace_trust_with_cornelia.lua

[eyes-and-brain]

Hi zach2good,

Thank you very much for your detailed explanation and for taking the time to dig up the historical data.

I have a basic understanding of the technical challenges you mentioned regarding the client-side behavior and the risks of ID conflicts during patch cycles. However, my main goal was to ensure that these definitions—even if commented out—remain documented in some form (comments, txt files, or discussions) so that the community has a historical record to refer to.

Currently, searching for "Matsui-P" in the discussions only brings up your "Module System v0.1." While I have tried the module and find it very useful, I was personally looking for a way to implement Cornelia as an independent trust.

To research the technical details, I’ve actually watched your videos in the Discord #ffx-captures channel many times to learn! (LOL) I'm truly grateful for the knowledge you've shared there.

Thank you again for providing the old PR data. It is incredibly helpful to see how it was handled in the past. I couldn't find these on my own, so I really appreciate you doing the "heavy lifting" to find them. This information is a goldmine for me!

Best regards,

[eyes-and-brain]

Hi zach2good,

Thank you again for the detailed information.

After looking into the tools you mentioned and trying out ResourceExtractor, I've realized that I can find many of these definitions (like Spell IDs) directly from the client data myself, even if they aren't explicitly defined in the current source code.

I feel a bit embarrassed about my lack of knowledge, but this has been a great learning experience for me. Thank you for pointing me in the right direction and for your patience. I'll continue to do more research on my end using these resources!

Best regards,