-
Notifications
You must be signed in to change notification settings - Fork 3
Description
Hey @akshaysubr. Just wanted to summarize the plan for integrating the healpixpad and python routines from earth2grid (link).
This is roughly what we discussed the other day.
- Move healpixpad cuda code in cuhpx.
- Move top-level python APIs (earth2grid.healpix -> cuhpx).
Please confirm this plan. I also had some questions about these topics:
Documentation
Earth2grid has sphinx documentation and sphinx gallery examples for HealPIX which are automatically deployed to github pages. Should we move that here?
Linting
Earth2grid has more python code, so it would be nice to use the linting setup from that project, and reformat the existing cuhpx code to comply if there are any linting errors. Is that okay?
Testing
Earth2grid has an existing test suite. the scripts in "tests" dir in cuHPX are not really unit tests, but instead are scripts that were run at some point to test the implementation. To enable pytest, we will need to rename these files to avoid pytest auto-discovering them and running them. In the long run, it would be nice to turn these into unit tests. It probably isn't that hard, and just requires wrapping in a function named def test_.
earth2grid is tested w/ CPUs on github actions, and then occasionally I manually test in the course of development on my GPU workstation. I don't think we need to worry about GPU testing in CI at the moment.