fix: prevent race conditions for concurrent npm-based server processes using same node_modules dir (diffplug#2786)

Author: nedtwigg

CHANGES.md

@@ -12,6 +12,8 @@ We adhere to the [keepachangelog](https://keepachangelog.com/en/1.0.0/) format (
 ## [Unreleased]
 ### Added
 - Add the ability to specify a wildcard version (`*`) for external formatter executables. ([#2757](https://github.com/diffplug/spotless/issues/2757))
+### Fixed
+- Prevent race conditions when multiple npm-based formatters launch the server process simultaneously while sharing the same `node_modules` directory. ([#2786](https://github.com/diffplug/spotless/pull/2786))
 ### Changes
 * Bump default `ktfmt` version to latest `0.59` -> `0.61`. ([2804](https://github.com/diffplug/spotless/pull/2804))
 * Bump default `ktlint` version to latest `1.7.1` -> `1.8.0`. ([2763](https://github.com/diffplug/spotless/pull/2763))

lib/src/main/resources/com/diffplug/spotless/npm/common-serve.js

@@ -35,12 +35,14 @@ function getInstanceId() {
 
 var listener = app.listen(0, "127.0.0.1", () => {
 	const instanceId = getInstanceId();
+	const tempFileName = `server-${instanceId}.port.tmp`;
+	const finalFileName = `server-${instanceId}.port`;
 	debugLog("Server running on port " + listener.address().port + " for instance " + instanceId);
-	fs.writeFile("server.port.tmp", "" + listener.address().port, function (err) {
+	fs.writeFile(tempFileName, "" + listener.address().port, function (err) {
 		if (err) {
 			return console.log(err);
 		} else {
-			fs.rename("server.port.tmp", `server-${instanceId}.port`, function (err) {
+			fs.rename(tempFileName, finalFileName, function (err) {
 				if (err) {
 					return console.log(err);
 				}

lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json

@@ -1,6 +1,6 @@
 {
 	"name": "spotless-eslint",
-	"version": "4.0.0",
+	"version": "4.0.1",
 	"description": "Spotless formatter step for running eslint as a rest service.",
 	"repository": "https://github.com/diffplug/spotless",
 	"license": "Apache-2.0",

lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json

@@ -1,6 +1,6 @@
 {
 	"name": "spotless-prettier",
-	"version": "4.0.0",
+	"version": "4.0.1",
 	"description": "Spotless formatter step for running prettier as a rest service.",
 	"repository": "https://github.com/diffplug/spotless",
 	"license": "Apache-2.0",

lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json

@@ -1,6 +1,6 @@
 {
 	"name": "spotless-tsfmt",
-	"version": "4.0.0",
+	"version": "4.0.1",
 	"description": "Spotless formatter step for running tsfmt as a rest service.",
 	"repository": "https://github.com/diffplug/spotless",
 	"license": "Apache-2.0",

plugin-gradle/CHANGES.md

@@ -7,6 +7,7 @@ We adhere to the [keepachangelog](https://keepachangelog.com/en/1.0.0/) format (
 - Add the ability to specify a wildcard version (`*`) for external formatter executables. ([#2757](https://github.com/diffplug/spotless/issues/2757))
 ### Fixed
 - [fix] `NPE` due to workingTreeIterator being null for git ignored files. #911 ([#2771](https://github.com/diffplug/spotless/issues/2771))
+- Prevent race conditions when multiple npm-based formatters launch the server process simultaneously while sharing the same `node_modules` directory. ([#2786](https://github.com/diffplug/spotless/pull/2786))
 ### Changes
 * Bump default `ktfmt` version to latest `0.59` -> `0.61`. ([2804](https://github.com/diffplug/spotless/pull/2804))
 * Bump default `ktlint` version to latest `1.7.1` -> `1.8.0`. ([2763](https://github.com/diffplug/spotless/pull/2763))

plugin-maven/CHANGES.md

@@ -7,6 +7,8 @@ We adhere to the [keepachangelog](https://keepachangelog.com/en/1.0.0/) format (
 - Add the ability to specify a wildcard version (`*`) for external formatter executables. ([#2757](https://github.com/diffplug/spotless/issues/2757))
 ### Fixed
 - [fix] `NPE` due to workingTreeIterator being null for git ignored files. #911 ([#2771](https://github.com/diffplug/spotless/issues/2771))
+- Prevent race conditions when multiple npm-based formatters launch the server process simultaneously while sharing the same `node_modules` directory. ([#2786](https://github.com/diffplug/spotless/pull/2786))
+
 ### Changes
 * Bump default `ktfmt` version to latest `0.59` -> `0.61`. ([2804](https://github.com/diffplug/spotless/pull/2804))
 * Bump default `ktlint` version to latest `1.7.1` -> `1.8.0`. ([2763](https://github.com/diffplug/spotless/pull/2763))