Adjust parsing legacy input when sposets are implicitly inside determiants#5461
Merged
ye-luo merged 3 commits intoQMCPACK:developfrom Apr 25, 2025
Merged
Adjust parsing legacy input when sposets are implicitly inside determiants#5461ye-luo merged 3 commits intoQMCPACK:developfrom
ye-luo merged 3 commits intoQMCPACK:developfrom
Conversation
prckent
approved these changes
Apr 25, 2025
Contributor
Author
|
Test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR changed how the legacy input was consumed. No change to the input.
I moved spsoet creation outside the determinant parsing/creation.
I also noticed that input tests were not exactly mimicking legacy. So I adjusted them.
There is one benefit. There was a bug that code crash if a requested sposet name cannot be found.
This PR will report a clean user error message.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
epyc-server
Checklist