Skip to content

Commit d8d739f

Browse files
authored
Re-add rhel8 roofline binaries (#122)
RHEL8 now being supported until EOS, rebuilding rhel8 bins for rocm7 (previously built for rocm7 rhel9). Remove roofline-rhel9-rocm7, replace with new roofline-rhel8-rocm7. Update check for roof bin. Update any doc mentions of rhel min support version back to rhel8. --------- Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
1 parent 2444c20 commit d8d739f

File tree

4 files changed

+2
-9
lines changed

4 files changed

+2
-9
lines changed

projects/rocprofiler-compute/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ Full documentation for ROCm Compute Profiler is available at [https://rocm.docs.
147147
* Changed the condition when Roofline PDFs are generated during general profiling and ``--roof-only`` profiling (skip only when ``--no-roof`` option is present).
148148
* Updated Roofline binaries:
149149
* Rebuild using latest ROCm stack
150-
* Minimum OS distribution support minimum for roofline feature is now Ubuntu 22.04, RHEL 9, and SLES15 SP6.
150+
* Minimum OS distribution support minimum for roofline feature is now Ubuntu 22.04, RHEL 8, and SLES15 SP6.
151151
* Fixed not detecting memory clock issue when using amd-smi
152152
* Fixed standalone GUI crashing
153153
* Fixed L2 read/write/atomic bandwidths on MI350
Binary file not shown.
Binary file not shown.

projects/rocprofiler-compute/src/utils/utils.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1206,19 +1206,13 @@ def detect_roofline(mspec):
12061206
console_error("roofline", msg)
12071207

12081208
# Must be a valid RHEL machine
1209-
elif rocm_ver == 6 and (
1209+
elif (
12101210
rhel_distro == "platform:el8"
12111211
or rhel_distro == "platform:al8"
12121212
or rhel_distro == "platform:el9"
12131213
or rhel_distro == "platform:el10"
12141214
):
1215-
# RHEL8 supported up to ROCm6
12161215
distro = "platform:el8"
1217-
elif rocm_ver == 7 and (
1218-
rhel_distro == "platform:el9" or rhel_distro == "platform:el10"
1219-
):
1220-
# ROCm7 supports RHEL9 and above
1221-
distro = "platform:el9"
12221216

12231217
# Must be a valid SLES machine
12241218
elif (
@@ -1247,7 +1241,6 @@ def mibench(args, mspec):
12471241

12481242
distro_map = {
12491243
"platform:el8": "rhel8",
1250-
"platform:el9": "rhel9",
12511244
"15.6": "sles15sp6",
12521245
"22.04": "ubuntu22_04",
12531246
}

0 commit comments

Comments
 (0)