Enable C# 8 nullable reference types

Author: RehanSaeed

Benchmarks/Serilog.Exceptions.Benchmark/BenchmarkException.cs

@@ -27,10 +27,10 @@ protected BenchmarkException(
         {
         }
 
-        public string ParamString { get; set; }
+        public string? ParamString { get; set; }
 
         public int ParamInt { get; set; }
 
-        public Point Point { get; set; }
+        public Point? Point { get; set; }
     }
 }

Benchmarks/Serilog.Exceptions.Benchmark/BenchmarkExceptionDestructurer.cs

@@ -18,18 +18,18 @@ public class BenchmarkExceptionDestructurer : ExceptionDestructurer
         public override void Destructure(
             Exception exception,
             IExceptionPropertiesBag propertiesBag,
-            Func<Exception, IReadOnlyDictionary<string, object>> destructureException)
+            Func<Exception, IReadOnlyDictionary<string, object?>?> destructureException)
         {
             base.Destructure(exception, propertiesBag, destructureException);
 
 #pragma warning disable CA1062 // Validate arguments of public methods
             var benchmarkException = (BenchmarkException)exception;
             propertiesBag.AddProperty("ParamString", benchmarkException.ParamString);
             propertiesBag.AddProperty("ParamInt", benchmarkException.ParamInt);
-            propertiesBag.AddProperty("Point", new Dictionary<string, object>
+            propertiesBag.AddProperty("Point", new Dictionary<string, object?>
             {
-                { "X", benchmarkException.Point.X },
-                { "Y", benchmarkException.Point.Y },
+                { "X", benchmarkException.Point?.X },
+                { "Y", benchmarkException.Point?.Y },
             });
 #pragma warning restore CA1062 // Validate arguments of public methods
         }

Benchmarks/Serilog.Exceptions.Benchmark/DestructuringBenchmark.cs

@@ -19,7 +19,7 @@ public class DestructuringBenchmark
     {
         private readonly ReflectionBasedDestructurer reflectionBasedDestructurer = new(10);
         private readonly BenchmarkExceptionDestructurer benchmarkExceptionDestructurer = new();
-        private BenchmarkException benchmarkException;
+        private BenchmarkException benchmarkException = default!;
 
         [GlobalSetup]
         public void Setup()
@@ -39,36 +39,36 @@ public void Setup()
             }
         }
 
-        public IReadOnlyDictionary<string, object> DestructureUsingReflectionDestructurer(Exception ex)
+        public IReadOnlyDictionary<string, object?> DestructureUsingReflectionDestructurer(Exception ex)
         {
             var bag = new ExceptionPropertiesBag(ex);
 
             this.reflectionBasedDestructurer.Destructure(
                 ex,
                 bag,
-                null);
+                null!);
 
             return bag.GetResultDictionary();
         }
 
         [Benchmark]
-        public IReadOnlyDictionary<string, object> ReflectionDestructurer() =>
+        public IReadOnlyDictionary<string, object?> ReflectionDestructurer() =>
             this.DestructureUsingReflectionDestructurer(this.benchmarkException);
 
-        public IReadOnlyDictionary<string, object> DestructureUsingCustomDestructurer(Exception ex)
+        public IReadOnlyDictionary<string, object?> DestructureUsingCustomDestructurer(Exception ex)
         {
             var bag = new ExceptionPropertiesBag(ex);
 
             this.benchmarkExceptionDestructurer.Destructure(
                 ex,
                 bag,
-                null);
+                null!);
 
             return bag.GetResultDictionary();
         }
 
         [Benchmark]
-        public IReadOnlyDictionary<string, object> CustomDestructurer() =>
+        public IReadOnlyDictionary<string, object?> CustomDestructurer() =>
             this.DestructureUsingCustomDestructurer(this.benchmarkException);
     }
 }

Benchmarks/Serilog.Exceptions.Benchmark/ExceptionPropertiesBag.cs

@@ -8,26 +8,26 @@ namespace Serilog.Exceptions.Benchmark
     internal class ExceptionPropertiesBag : IExceptionPropertiesBag
     {
         private readonly Exception exception;
-        private readonly IExceptionPropertyFilter filter;
-        private readonly Dictionary<string, object> properties = new();
+        private readonly IExceptionPropertyFilter? filter;
+        private readonly Dictionary<string, object?> properties = new();
 
         // We keep a note on whether the results were collected to be sure that
         // after that there are no changes. This is the application of fail-fast principle.
         private bool resultsCollected;
 
-        public ExceptionPropertiesBag(Exception exception, IExceptionPropertyFilter filter = null)
+        public ExceptionPropertiesBag(Exception exception, IExceptionPropertyFilter? filter = null)
         {
             this.exception = exception ?? throw new ArgumentNullException(nameof(exception));
             this.filter = filter;
         }
 
-        public IReadOnlyDictionary<string, object> GetResultDictionary()
+        public IReadOnlyDictionary<string, object?> GetResultDictionary()
         {
             this.resultsCollected = true;
             return this.properties;
         }
 
-        public void AddProperty(string key, object value)
+        public void AddProperty(string key, object? value)
         {
             if (key is null)
             {

Directory.Build.props

@@ -4,6 +4,7 @@
     <LangVersion>latest</LangVersion>
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
     <AnalysisLevel>latest</AnalysisLevel>
+    <Nullable>enable</Nullable>
     <NeutralLanguage>en-GB</NeutralLanguage>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>

Source/Serilog.Exceptions.EntityFrameworkCore/Destructurers/DbUpdateExceptionDestructurer.cs

@@ -20,7 +20,7 @@ public class DbUpdateExceptionDestructurer : ExceptionDestructurer
         public override void Destructure(
             Exception exception,
             IExceptionPropertiesBag propertiesBag,
-            Func<Exception, IReadOnlyDictionary<string, object>> destructureException)
+            Func<Exception, IReadOnlyDictionary<string, object?>?> destructureException)
         {
             base.Destructure(exception, propertiesBag, destructureException);
 

Source/Serilog.Exceptions.MsSqlServer/Destructurers/SqlExceptionDestructurer.cs

@@ -20,7 +20,7 @@ public class SqlExceptionDestructurer : ExceptionDestructurer
         public override void Destructure(
             Exception exception,
             IExceptionPropertiesBag propertiesBag,
-            Func<Exception, IReadOnlyDictionary<string, object>> destructureException)
+            Func<Exception, IReadOnlyDictionary<string, object?>?> destructureException)
         {
             base.Destructure(exception, propertiesBag, destructureException);
 

Source/Serilog.Exceptions.SqlServer/Destructurers/SqlExceptionDestructurer.cs

@@ -20,7 +20,7 @@ public class SqlExceptionDestructurer : ExceptionDestructurer
         public override void Destructure(
             Exception exception,
             IExceptionPropertiesBag propertiesBag,
-            Func<Exception, IReadOnlyDictionary<string, object>> destructureException)
+            Func<Exception, IReadOnlyDictionary<string, object?>?> destructureException)
         {
             base.Destructure(exception, propertiesBag, destructureException);
 
@@ -36,4 +36,4 @@ public override void Destructure(
 #pragma warning restore CA1062 // Validate arguments of public methods
         }
     }
-}
+}

Source/Serilog.Exceptions/Core/DestructuringOptionsBuilder.cs

@@ -67,7 +67,7 @@ public class DestructuringOptionsBuilder : IDestructuringOptions
         /// <summary>
         /// Gets a global filter, that will be applied to every destructured property just before it is added to the result.
         /// </summary>
-        public IExceptionPropertyFilter Filter { get; private set; }
+        public IExceptionPropertyFilter? Filter { get; private set; }
 
         /// <summary>
         /// Accumulates destructurers to be used by <see cref="ExceptionEnricher"/>.

Source/Serilog.Exceptions/Core/ExceptionEnricher.cs

@@ -74,7 +74,7 @@ public void Enrich(LogEvent logEvent, ILogEventPropertyFactory propertyFactory)
             }
         }
 
-        private IReadOnlyDictionary<string, object> DestructureException(Exception exception)
+        private IReadOnlyDictionary<string, object?>? DestructureException(Exception exception)
         {
             var exceptionType = exception.GetType();