Skip to content

Commit 97af52c

Browse files
authored
[worker,rollout] refactor: remove set_expandable_segments calls in vllm separation mode (verl-project#5144)
### What does this PR do? vllm rollout now is in separation process. So it's no need to switch expandable ### Checklist Before Starting - [ ] Search for similar PRs. Paste at least one query link here: ... - [ ] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `veomni`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data`, `cfg`, `reward` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [ ] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [ ] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [ ] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).) - [ ] If your PR is related to the `recipe` submodule, please also update the reference to the submodule commit via `git submodule update --remote` or `cd recipe && git pull origin main`.
1 parent e363d60 commit 97af52c

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

verl/workers/engine_workers.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
from verl.single_controller.base.decorator import Dispatch, make_nd_compute_dataproto_dispatch_fn, register
3333
from verl.utils import tensordict_utils as tu
3434
from verl.utils.config import omega_conf_to_dataclass
35-
from verl.utils.device import get_device_name, set_expandable_segments
35+
from verl.utils.device import get_device_name
3636
from verl.utils.distributed import initialize_global_process_group_ray
3737
from verl.utils.flops_counter import FlopsCounter
3838
from verl.utils.memory_utils import aggressive_empty_cache
@@ -595,7 +595,6 @@ async def update_weights(self):
595595
await self.checkpoint_engine.send_weights(per_tensor_param)
596596
return
597597

598-
set_expandable_segments(False)
599598
# 1. resume weights and update weights
600599
if self.config.rollout.free_cache_engine:
601600
await self.rollout.resume(tags=["weights"])
@@ -635,7 +634,6 @@ async def update_weights(self):
635634
log_gpu_memory_usage("After resume kv_cache", logger=logger)
636635

637636
self.base_sync_done = True
638-
set_expandable_segments(True)
639637

640638
@register(dispatch_mode=Dispatch.DP_COMPUTE, blocking=False)
641639
def execute_checkpoint_engine(self, method: str, *args, **kwargs):

0 commit comments

Comments
 (0)