Merge pull request #3357 from SUSE/reduce_reduce

Remove unnecessary uses of reduce()

Author: dirkmueller

src/staging/bot.py

@@ -16,7 +16,6 @@
 from datetime import timedelta
 from enum import Enum
 from enum import unique
-from functools import reduce
 from io import BytesIO
 from pathlib import Path
 from typing import ClassVar
@@ -186,7 +185,7 @@ def __post_init__(self) -> None:
             self.branch_name = (
                 self.deployment_branch_name
                 + "-"
-                + "".join(random.choice(string.ascii_letters) for _ in range(5))
+                + "".join(random.choices(string.ascii_letters, k=5))
             )
 
         if not self.osc_username:
@@ -832,17 +831,7 @@ def _get_changed_packages_by_commit(self, commit: str | git.Commit) -> list[str]
                     packages.append(b_path[0])
 
         res = list(set(packages))
-
-        # it can happen that we only update a non-BCI package file,
-        # e.g. .obs/workflows.yml, then we will have a commit, but the diff will
-        # not touch any BCI and thus `res` will be an empty list
-        # => give reduce an initial value (last parameter) as it will otherwise
-        #    fail
-        assert reduce(
-            lambda folder_a, folder_b: folder_a and folder_b,
-            (pkg in bci_pkg_names for pkg in res),
-            True,
-        )
+        assert all(pkg in bci_pkg_names for pkg in res)
         return res
 
     async def _run_git_action_in_worktree(