Conversation
|
Created a staging project on OBS for 7: home:pushman:BCI:Staging:SLE-15-SP7:7-3374 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=15.7 TARGET=custom BASEURL=registry.opensuse.org/home/pushman/bci/staging/sle-15-sp7/7-3374/ tox -- -n autoThe following images can be pulled from the staging project:
|
|
can you please merge the last two commits? otherwise git doesn't detect them as renames and generates a rather large diff.. also the DOTNET_VERSION is now set to empty rather than the version number, which looks like there is something broken. |
dirkmueller
left a comment
dirkmueller
left a comment
There was a problem hiding this comment.
in the CI diff, you can see that DOTNET_VERSION is now set to empty.
alexandrevicenzi
force-pushed
the
third-rarty-repo
branch
from
c6477a9 to
d15ea2b
Compare
alexandrevicenzi
force-pushed
the
third-rarty-repo
branch
from
d15ea2b to
438ad12
Compare
Merged both commits, but it does not seem to detect the rename. DOTNET_VERSION is fixed, it was an undefined variable in the template. |
src/bci_build/package/thirdparty.py
Outdated
| {%- endwith %} | ||
| {%- endfor %} | ||
|
|
||
| COPY third-party.repo /etc/zypp/repos.d/{{ image.name }}.repo |
There was a problem hiding this comment.
do we really need to name the repo different for every container? I found the previous naming of just using hte 3rd party name much more convenient (also this breaks tests, but that could be fixed). what's the rationale for this?
There was a problem hiding this comment.
No strong reasons for this naming.
There was a problem hiding this comment.
Since this is generic code, I can't keep the original .NET name here, but I made it static, all containers are going to have the same name, which is third-party.repo/
There was a problem hiding this comment.
thanks, but my concern was on the group name within, as that is used as repository name. I agree we cannot use it for everything, but maybe we can just make it settable and set it to the previous name? then it could potentially stack, in case we ever have the need for multiple third party repos.
There was a problem hiding this comment.
I added a way to set the files to the previous names.
It is not possible to stack multiple third-party repos, everything would need to become some sort of a list.
dirkmueller
left a comment
dirkmueller
left a comment
There was a problem hiding this comment.
what happened to the _fetch_dotnet_host() logic? seems gone. also see more inline comments.
this needs a bit more work. I do like moving around the files to the new location, but intermixing that with many subtle logic changes makes reviewing rather hard.
Yes, it was removed. I think I completely misunderstood what |
alexandrevicenzi
force-pushed
the
third-rarty-repo
branch
from
438ad12 to
299f89c
Compare
|
@dirkmueller I restored the original logic for There are still significant changes of code moving around, but I tried to preserve important bits as much as possible and make it also reusable for the AMG GPU container. |
It helps when exporting localy, otherwise it requires to create paths manually.
Migrate .NET images to the new ThirdPartyRepoMixin. This allow images to use third-party repositories easily.
alexandrevicenzi
force-pushed
the
third-rarty-repo
branch
from
299f89c to
bff6463
Compare
2 participants
This includes:
This will also be used by the AMD GPU driver image.