🔄 synced local 'skyvern/' with remote 'skyvern/'

## Summary

- Fix critical bug where `self._page` was used instead of `self.page` in `_wait_for_page_ready_before_action`
- **Added diagnostic logging** for screenshot timeouts to help debug Flinks issues

## Bug Fix

The `SkyvernPage` class uses `self.page` but `_wait_for_page_ready_before_action` was checking `self._page` which doesn't exist. This caused every cached script action to log:
```
AttributeError: 'ScriptSkyvernPage' object has no attribute '_page'
```

## Added Logging for Screenshot Diagnostics

### Screenshot timeout now logs context:
```
Screenshot timeout | timeout_ms=3000 | url=https://... | viewport=1920x1080 | full_page=False | mode=detailed
```

### Scrape retry attempts now logged:
```
Scrape attempt failed, will retry with next strategy | attempt=1 | scrape_type=normal | error_type=FailedToTakeScreenshot | url=...
Scrape attempt failed, will retry with next strategy | attempt=2 | scrape_type=normal | error_type=FailedToTakeScreenshot | url=...
All scrape attempts failed | total_attempts=3 | error_type=FailedToTakeScreenshot | url=... | step_order=0 | step_retry=1
```

This will help identify:
- **Which URLs** are causing timeouts
- **What timeout value** is actually being used
- **Page viewport size** (large pages may timeout)
- **Which retry attempt** failed
- **Step context** (order and retry index)

## Test plan

- [ ] Deploy to staging and verify logs appear correctly
- [ ] Have Nick deploy and check if new logs provide insight into slowness
- [ ] Monitor for patterns in failing URLs/viewport sizes

🤖 Generated with [Claude Code](https://claude.ai/claude-code)

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

* **Refactor**
  * Use the public page attribute for readiness handling to improve stability when a page is unavailable.

* **Chores / Diagnostics**
  * Enhanced screenshot error/debug logs with URL and viewport info.
  * Improved scrape retry and failure logs to include attempt counts, error context, and next-step details.

* **Tests**
  * Added unit tests validating readiness behavior and resilience around frame creation and wait routines.

<sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub>
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- ELLIPSIS_HIDDEN -->

----

> [!IMPORTANT]
> Fix `AttributeError` in `ScriptSkyvernPage` and enhance logging for diagnostics.
>
>   - **Bug Fix**:
>     - Fix `AttributeError` in `ScriptSkyvernPage._wait_for_page_ready_before_action` by replacing `self._page` with `self.page`.
>   - **Logging Enhancements**:
>     - Add detailed logging for screenshot timeouts in `_current_viewpoint_screenshot_helper()` in `page.py`.
>     - Log scrape retry attempts and failures in `build_and_record_step_prompt()` in `agent.py`.
>   - **Testing**:
>     - Add unit tests in `test_script_skyvern_page.py` to verify correct attribute access and exception handling in `_wait_for_page_ready_before_action`.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for cbe137ff395b4ef7b17a3b86bf839e46fc357a1f. You can [customize](https://app.ellipsis.dev/Skyvern-AI/settings/summaries) this summary. It will automatically update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->

Author: pedrohsdb

skyvern/core/script_generations/script_skyvern_page.py

@@ -546,10 +546,11 @@ async def _wait_for_page_ready_before_action(self) -> None:
         3. DOM stability (no significant mutations for 300ms)
         """
         try:
-            if not self._page:
+            # Note: SkyvernPage uses self.page, not self._page
+            if not self.page:
                 return
 
-            skyvern_frame = await SkyvernFrame.create_instance(frame=self._page)
+            skyvern_frame = await SkyvernFrame.create_instance(frame=self.page)
             await skyvern_frame.wait_for_page_ready(
                 network_idle_timeout_ms=settings.PAGE_READY_NETWORK_IDLE_TIMEOUT_MS,
                 loading_indicator_timeout_ms=settings.PAGE_READY_LOADING_INDICATOR_TIMEOUT_MS,

skyvern/forge/agent.py

@@ -2456,8 +2456,23 @@ async def build_and_record_step_prompt(
                     break
                 except (FailedToTakeScreenshot, ScrapingFailed) as e:
                     if idx < len(SCRAPE_TYPE_ORDER) - 1:
+                        LOG.warning(
+                            "Scrape attempt failed, will retry with next strategy",
+                            attempt=idx + 1,
+                            scrape_type=scrape_type.value if hasattr(scrape_type, "value") else str(scrape_type),
+                            error_type=e.__class__.__name__,
+                            url=task.url,
+                        )
                         continue
-                    LOG.exception(f"{e.__class__.__name__} happened in two normal attempts and reload-page retry")
+                    LOG.error(
+                        "All scrape attempts failed",
+                        total_attempts=len(SCRAPE_TYPE_ORDER),
+                        error_type=e.__class__.__name__,
+                        url=task.url,
+                        step_order=step.order,
+                        step_retry=step.retry_index,
+                        exc_info=True,
+                    )
                     raise e
 
         if scraped_page is None:

skyvern/webeye/utils/page.py

@@ -74,6 +74,15 @@ async def _current_viewpoint_screenshot_helper(
 ) -> bytes:
     if page.is_closed():
         raise FailedToTakeScreenshot(error_message="Page is closed")
+
+    # Capture page context for debugging screenshot issues
+    url = page.url
+    try:
+        viewport = page.viewport_size
+        viewport_info = f"{viewport['width']}x{viewport['height']}" if viewport else "unknown"
+    except Exception:
+        viewport_info = "unknown"
+
     try:
         if mode == ScreenshotMode.DETAILED:
             await page.wait_for_load_state(timeout=SettingsManager.get_settings().BROWSER_LOADING_TIMEOUT_MS)
@@ -94,10 +103,25 @@ async def _current_viewpoint_screenshot_helper(
         )
         return screenshot
     except TimeoutError as e:
-        LOG.exception(f"Timeout error while taking screenshot: {str(e)}")
+        LOG.error(
+            "Screenshot timeout",
+            timeout_ms=timeout,
+            url=url,
+            viewport=viewport_info,
+            full_page=full_page,
+            mode=mode.value if hasattr(mode, "value") else str(mode),
+            error=str(e),
+        )
         raise FailedToTakeScreenshot(error_message=str(e)) from e
     except Exception as e:
-        LOG.exception(f"Unknown error while taking screenshot: {str(e)}")
+        LOG.error(
+            "Screenshot failed",
+            url=url,
+            viewport=viewport_info,
+            full_page=full_page,
+            error=str(e),
+            exc_info=True,
+        )
         raise FailedToTakeScreenshot(error_message=str(e)) from e