-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Summary
Extracting archive files (zip, etc.) on remote providers like Google Drive doesn't work properly. It shows an error, displays a non-functional progress window, then unexpectedly opens Finder.
Current State
- File:
src/store/useAppStore.ts:1300-1421(extractArchive function) - Google Drive extraction flow exists at lines 1342-1421
- The code attempts to:
- Get the destination folder ID
- Call
extract_gdrive_archivebackend command - Show progress window after 500ms delay
- Refresh directory on completion
Current behavior (broken):
- User double-clicks a zip file on Google Drive
- Error appears (unclear what error)
- Progress window shows but doesn't reflect actual progress
- Finder opens for some reason (likely fallback behavior at line 1493:
await openShell(file.path)) - Archive is not extracted
Code flow issue:
} catch (error) {
// ... error handling ...
try {
await openShell(file.path); // <-- This opens Finder with the gdrive:// path
return false;
} catch (openErr) {
// ...
}
}The fallback openShell(file.path) on a gdrive:// path doesn't make sense and causes Finder to open.
Proposed Changes
Option A: Disable extraction for remote providers (quick fix)
- Show a clear message: "Archive extraction is not yet supported for Google Drive. Download the file first."
- Don't show progress window or attempt extraction
- Don't fall back to opening in Finder
Option B: Implement proper remote extraction (full fix)
- Download archive to temp directory
- Extract locally
- Upload extracted contents back to remote
- Show accurate progress (download → extract → upload phases)
- Clean up temp files
Immediate fixes needed:
- Don't call
openShell()with remote paths on failure - Either disable the feature cleanly or implement it properly
- Progress window should reflect actual state or not appear at all
Technical Notes
extract_gdrive_archivecommand exists in backend:src-tauri/src/commands.rs- Progress window:
src/windows/ArchiveProgressWindow.tsx - Archive progress store:
src/store/useArchiveProgressStore.ts - Similar issue likely affects SMB paths
Acceptance Criteria
- No confusing error + progress + Finder behavior
- Clear user feedback on what's happening
- Either: extraction works end-to-end, OR clear message that it's not supported
- No fallback to
openShell()with remote paths
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working