Magic fog around potions is missing, light problem

[mztulip]

Describe the bug

1. I called it magic fog, but it looks like dissapearing blue stars around potions.
   Video presents how it look in original game.

2. Another problem captured on the screen is light. In this place is light source and it is very strong and white. This is general problem. Torch gives similar effect. (brightness in options is reduced to minimum))

Save-game/Log-file/Screenshots/Video

potion.webm

Screenshot from open gothic.

potion_save_slot_5.zip

Commit: f0ca41d

[Try]

Hi, @mztulip!

Yes, I'm aware of both cases.

1. This is optional feature, that OpenGothic hasn't implemented due to uncertainty about performance. This 'magic fog' is particle system, with mesh-emitter. Particles have to run on CPU and that already unpleasant, and with large view range that might me an issue. Never found time to do in-depth performance analysis on those.

2. Game world has a tons of lights, and it's unclear how to handle those
   2.1. They have no lighting units (duh), so there are some hacks in rendering code to make them bypass exposure
   2.2 Some of them, like in example are non visible in vanilla. I don't know why exactly. Maybe due to DX7 limit of ~7 light sources. Maybe some of them are only mean for lightmaps
   2.3 not to mention amount of light is over the top even for modern gpu in some cases.

[mztulip]

Ad1
Thanks, I understand 'magic fog' now, and why view distance is important in vanilla. But this effect is very useful for finding items like old table or potion. Maybe it will be easy to replace it with something. Like making this element brighter or add something like constant bright aura around?

Ad2
This light is visible in vanilla, but is weak.
This can be observed on this screen:

There is also another source on the way to Khorinis from Xardas tower.

In original engine this source is weak.

Another example, candle in Xardas tower:

Also is very strong, but should be weak.

[Try]

Maybe it will be easy to replace it with something. Like making this element brighter or add something like constant bright aura around?

It's more about finding enough time, unfortunately :(
Ideally I would like to rework particles rendering as well, but there is a camera issue and would like to figure collisions as well.

Another example, candle in Xardas tower:

Yeah. It's not really an option to 'just' dim them - in that case city lighting at night will become dimmer as well.
It's also possible, that in vanilla, those lights are bright(numerically), but DX7 driver ruins the rendering.