Fix string array equality when the values buffer is the same and only the offsets to access it differ #9325
+55
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…offsets into it differ
Jefffrey
approved these changes
Feb 2, 2026
Contributor
Jefffrey
left a comment
Jefffrey
left a comment
There was a problem hiding this comment.
Should be good to go once clippy is fixed
Contributor
Author
Thanks, I always forget the |
10 tasks
alamb
approved these changes
Feb 2, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Makes sense to me - thanks @Jefffrey and @jhorstmann
I will also create a PR to backport this to the 57 patch release
alamb
pushed a commit
to alamb/arrow-rs
that referenced
this pull request
Feb 2, 2026
… the offsets to access it differ (apache#9325) # Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Closes apache#9323. # Rationale for this change This bug seems to have existed for at least the last 5 years (before that, array equality had a lot more issues with offsets). <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are these changes tested? Tested with unit tests. # Are there any user-facing changes? no
alamb
added a commit
that referenced
this pull request
Feb 2, 2026
…the same and only the offsets to access it differ (#9325) (#9330) - Part of #9240 - Related to #9323 This is a backport of the following PR to the 57 line - #9325 from @jhorstmann Co-authored-by: Jörn Horstmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This bug seems to have existed for at least the last 5 years (before that, array equality had a lot more issues with offsets).
What changes are included in this PR?
Are these changes tested?
Tested with unit tests.
Are there any user-facing changes?
no