Skip to content

Commit 3f92d30

Browse files
committed
fix-divider
1 parent 4c85a33 commit 3f92d30

File tree

1 file changed

+21
-1
lines changed
  • superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/ConfigModalSidebar

1 file changed

+21
-1
lines changed

superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/ConfigModalSidebar/ConfigModalSidebar.tsx

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import NewItemDropdown from '../NewItemDropdown';
3232
import ItemSectionContent from './ItemSection';
3333
import { FilterRemoval } from '../types';
3434
import { FILTER_TYPE, CUSTOMIZATION_TYPE } from '../DraggableFilter';
35-
import { isFilterId, isChartCustomizationId } from '../utils';
35+
import { isFilterId, isChartCustomizationId, isDivider } from '../utils';
3636

3737
const StyledSidebarFlex = styled(Flex)`
3838
min-width: 290px;
@@ -172,6 +172,26 @@ const ConfigModalSidebar: FC<ConfigModalSidebarProps> = ({
172172
return;
173173
}
174174

175+
if (
176+
onCrossListDrop &&
177+
typeof active.id === 'string' &&
178+
isDivider(active.id) &&
179+
((activeFilterIndex !== -1 && overCustomizationIndex !== -1) ||
180+
(activeCustomizationIndex !== -1 && overFilterIndex !== -1))
181+
) {
182+
const sourceType: 'filter' | 'customization' =
183+
activeFilterIndex !== -1 ? 'filter' : 'customization';
184+
const targetType: 'filter' | 'customization' =
185+
sourceType === 'filter' ? 'customization' : 'filter';
186+
const targetIndex =
187+
targetType === 'filter' ? overFilterIndex : overCustomizationIndex;
188+
189+
if (targetIndex !== -1) {
190+
onCrossListDrop(active.id, targetIndex, sourceType, targetType);
191+
}
192+
return;
193+
}
194+
175195
if (activeFilterIndex !== -1 && overFilterIndex !== -1) {
176196
const itemId = filterOrderedIds[activeFilterIndex];
177197
onRearrange(activeFilterIndex, overFilterIndex, itemId);

0 commit comments

Comments
 (0)