Skip to content

Commit f51b559

Browse files
dididytbonelee
authored andcommitted
[HOTFIX] @playwright/test 1.56.1 to 1.55.1
### What is this PR for? #5111 (comment) #5108 After upgrading Playwright to the latest version(1.53.2 to 1.56.1), several test cases started failing on WebKit. The issue was resolved by rolling back to the previous minor version(1.55.1). [related issue] microsoft/playwright#37766 ### What type of PR is it? Hot Fix ### Todos ### What is the Jira issue? ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #5115 from dididy/fix/e2e. Signed-off-by: ChanHo Lee <[email protected]> (cherry picked from commit bf62a2a) Signed-off-by: ChanHo Lee <[email protected]>
1 parent b90b277 commit f51b559

File tree

6 files changed

+37
-69
lines changed

6 files changed

+37
-69
lines changed

zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-edit.spec.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,7 @@ test.describe('Notebook Repository Item - Edit Mode', () => {
7373
}
7474

7575
const firstRow = repoItemPage.settingRows.first();
76-
const settingName =
77-
(await firstRow
78-
.locator('td')
79-
.first()
80-
.textContent()) || '';
76+
const settingName = (await firstRow.locator('td').first().textContent()) || '';
8177
const originalValue = await repoItemPage.getSettingValue(settingName);
8278

8379
await repoItemPage.clickEdit();

zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-form-validation.spec.ts

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,7 @@ test.describe('Notebook Repository Item - Form Validation', () => {
4646
await repoItemPage.clickEdit();
4747

4848
const firstRow = repoItemPage.settingRows.first();
49-
const settingName =
50-
(await firstRow
51-
.locator('td')
52-
.first()
53-
.textContent()) || '';
49+
const settingName = (await firstRow.locator('td').first().textContent()) || '';
5450

5551
const isInputVisible = await repoItemPage.isInputVisible(settingName);
5652
if (isInputVisible) {
@@ -73,11 +69,7 @@ test.describe('Notebook Repository Item - Form Validation', () => {
7369
await repoItemPage.clickEdit();
7470

7571
const firstRow = repoItemPage.settingRows.first();
76-
const settingName =
77-
(await firstRow
78-
.locator('td')
79-
.first()
80-
.textContent()) || '';
72+
const settingName = (await firstRow.locator('td').first().textContent()) || '';
8173

8274
const isInputVisible = await repoItemPage.isInputVisible(settingName);
8375
if (isInputVisible) {
@@ -102,11 +94,7 @@ test.describe('Notebook Repository Item - Form Validation', () => {
10294

10395
for (let i = 0; i < settingRows; i++) {
10496
const row = repoItemPage.settingRows.nth(i);
105-
const settingName =
106-
(await row
107-
.locator('td')
108-
.first()
109-
.textContent()) || '';
97+
const settingName = (await row.locator('td').first().textContent()) || '';
11098

11199
const isInputVisible = await repoItemPage.isInputVisible(settingName);
112100
if (isInputVisible) {

zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-settings.spec.ts

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,7 @@ test.describe('Notebook Repository Item - Settings', () => {
6060

6161
for (let i = 0; i < settingRows; i++) {
6262
const row = repoItemPage.settingRows.nth(i);
63-
const settingName =
64-
(await row
65-
.locator('td')
66-
.first()
67-
.textContent()) || '';
63+
const settingName = (await row.locator('td').first().textContent()) || '';
6864

6965
const isInputVisible = await repoItemPage.isInputVisible(settingName);
7066
if (isInputVisible) {
@@ -86,11 +82,7 @@ test.describe('Notebook Repository Item - Settings', () => {
8682

8783
for (let i = 0; i < settingRows; i++) {
8884
const row = repoItemPage.settingRows.nth(i);
89-
const settingName =
90-
(await row
91-
.locator('td')
92-
.first()
93-
.textContent()) || '';
85+
const settingName = (await row.locator('td').first().textContent()) || '';
9486

9587
const isDropdownVisible = await repoItemPage.isDropdownVisible(settingName);
9688
if (isDropdownVisible) {
@@ -112,11 +104,7 @@ test.describe('Notebook Repository Item - Settings', () => {
112104
let foundInput = false;
113105
for (let i = 0; i < settingRows; i++) {
114106
const row = repoItemPage.settingRows.nth(i);
115-
const settingName =
116-
(await row
117-
.locator('td')
118-
.first()
119-
.textContent()) || '';
107+
const settingName = (await row.locator('td').first().textContent()) || '';
120108

121109
const isInputVisible = await repoItemPage.isInputVisible(settingName);
122110
if (isInputVisible) {

zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-workflow.spec.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,7 @@ test.describe('Notebook Repository Item - Edit Workflow', () => {
5151
let foundSetting = false;
5252
for (let i = 0; i < settingRows; i++) {
5353
const row = repoItemPage.settingRows.nth(i);
54-
const settingName =
55-
(await row
56-
.locator('td')
57-
.first()
58-
.textContent()) || '';
54+
const settingName = (await row.locator('td').first().textContent()) || '';
5955

6056
const isInputVisible = await repoItemPage.isInputVisible(settingName);
6157
if (isInputVisible) {
@@ -91,11 +87,7 @@ test.describe('Notebook Repository Item - Edit Workflow', () => {
9187
await repoItemUtil.verifyDisplayMode();
9288

9389
const firstRow = repoItemPage.settingRows.first();
94-
const settingName =
95-
(await firstRow
96-
.locator('td')
97-
.first()
98-
.textContent()) || '';
90+
const settingName = (await firstRow.locator('td').first().textContent()) || '';
9991
const originalValue = await repoItemPage.getSettingValue(settingName);
10092

10193
await repoItemPage.clickEdit();

zeppelin-web-angular/package-lock.json

Lines changed: 27 additions & 23 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

zeppelin-web-angular/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
"@angular/cli": "~13.3.11",
7070
"@angular/compiler-cli": "~13.4.0",
7171
"@angular/language-service": "~13.4.0",
72-
"@playwright/test": "1.56.1",
72+
"@playwright/test": "1.55.1",
7373
"@types/angular": "^1.8.0",
7474
"@types/diff-match-patch": "^1.0.36",
7575
"@types/highlight.js": "^9.12.3",

0 commit comments

Comments
 (0)