rename to timeoutMs and move to install options

Author: navin772

src/services/ios/installation-proxy/index.ts

@@ -193,73 +193,73 @@ export class InstallationProxyService extends BaseService {
    * @param packagePath Path to the IPA file on the device (e.g., '/PublicStaging/app.ipa')
    * @param options Installation options
    * @param progressCallback Optional callback for progress updates
-   * @param operationTimeout Optional timeout in milliseconds for the entire operation (default: 10 minutes)
    */
   async install(
     packagePath: string,
     options: InstallOptions = {},
     progressCallback?: ProgressCallback,
-    operationTimeout?: number,
   ): Promise<void> {
     log.debug(`Installing app from: ${packagePath}`);
 
+    const { timeoutMs, ...clientOptions } = options;
+
     const request: PlistDictionary = {
       Command: 'Install',
       PackagePath: packagePath,
-      ClientOptions: options as PlistDictionary,
+      ClientOptions: clientOptions as PlistDictionary,
     };
 
-    await this.executeWithProgress(request, progressCallback, operationTimeout);
+    await this.executeWithProgress(request, progressCallback, timeoutMs);
     log.info('Installation complete');
   }
 
   /**
    * Uninstall an application by bundle identifier
    * @param bundleIdentifier Bundle ID of the app to uninstall
-   * @param options Uninstallation options
+   * @param options Uninstallation options (including optional timeoutMs)
    * @param progressCallback Optional callback for progress updates
-   * @param operationTimeout Optional timeout in milliseconds for the entire operation (default: 10 minutes)
    */
   async uninstall(
     bundleIdentifier: string,
     options: UninstallOptions = {},
     progressCallback?: ProgressCallback,
-    operationTimeout?: number,
   ): Promise<void> {
     log.debug(`Uninstalling app: ${bundleIdentifier}`);
 
+    const { timeoutMs, ...clientOptions } = options;
+
     const request: PlistDictionary = {
       Command: 'Uninstall',
       ApplicationIdentifier: bundleIdentifier,
-      ClientOptions: options as PlistDictionary,
+      ClientOptions: clientOptions as PlistDictionary,
     };
 
-    await this.executeWithProgress(request, progressCallback, operationTimeout);
+    await this.executeWithProgress(request, progressCallback, timeoutMs);
     log.info('Uninstallation complete');
   }
 
   /**
    * Upgrade an existing application
    * @param packagePath Path to the IPA file on the device (e.g., '/PublicStaging/app.ipa')
-   * @param options Installation options
+   * @param options Installation options (including optional timeoutMs)
    * @param progressCallback Optional callback for progress updates
-   * @param operationTimeout Optional timeout in milliseconds for the entire operation (default: 10 minutes)
    */
   async upgrade(
     packagePath: string,
     options: InstallOptions = {},
     progressCallback?: ProgressCallback,
-    operationTimeout?: number,
   ): Promise<void> {
     log.debug(`Upgrading app from: ${packagePath}`);
 
+    const { timeoutMs, ...clientOptions } = options;
+
     const request: PlistDictionary = {
       Command: 'Upgrade',
       PackagePath: packagePath,
-      ClientOptions: options as PlistDictionary,
+      ClientOptions: clientOptions as PlistDictionary,
     };
 
-    await this.executeWithProgress(request, progressCallback, operationTimeout);
+    await this.executeWithProgress(request, progressCallback, timeoutMs);
     log.info('Upgrade complete');
   }
 
@@ -361,17 +361,17 @@ export class InstallationProxyService extends BaseService {
   private async executeWithProgress(
     request: PlistDictionary,
     progressCallback?: ProgressCallback,
-    operationTimeout: number = MAX_INSTALL_DURATION_MS,
+    timeoutMs: number = MAX_INSTALL_DURATION_MS,
   ): Promise<void> {
     const conn = await this.getConnection();
     conn.sendPlist(request);
 
     const startTime = performance.now();
 
     while (true) {
-      if (performance.now() - startTime > operationTimeout) {
+      if (performance.now() - startTime > timeoutMs) {
         throw new Error(
-          `Operation exceeded maximum duration (${operationTimeout / 1000}s). ` +
+          `Operation exceeded maximum duration (${timeoutMs / 1000}s). ` +
             'This likely indicates a stalled operation or API issue.',
         );
       }

src/services/ios/installation-proxy/types.ts

@@ -12,10 +12,12 @@ export interface BrowseOptions {
 
 export interface InstallOptions {
   packageType?: string;
+  timeoutMs?: number;
   [key: string]: string | number | boolean | undefined;
 }
 
 export interface UninstallOptions {
+  timeoutMs?: number;
   [key: string]: string | number | boolean | undefined;
 }