moar

Author: mykola-mokhnach

.github/workflows/format-check.yml

@@ -7,36 +7,21 @@ on:
     branches: [ main ]
 
 jobs:
-  prepare_matrix:
-    runs-on: ubuntu-latest
-    outputs:
-      versions: ${{ steps.generate-matrix.outputs.lts }}
-    steps:
-    - name: Select all current LTS versions of Node.js
-      id: generate-matrix
-      uses: msimerson/node-lts-versions@v1
-
   format-check:
     runs-on: macos-latest
-    needs:
-    - prepare_matrix
-    strategy:
-      fail-fast: false
-      matrix:
-        node-version: ${{ fromJSON(needs.prepare_matrix.outputs.versions) }}
     steps:
     - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v3
-    - name: Use Node.js ${{ matrix.node-version }}
+    - name: Use Node.js (LTS)
       uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v3
       with:
-        node-version: ${{ matrix.node-version }}
+        node-version: 'lts/*'
     - name: Install dependencies
       run: npm install
-    
+
     - name: Check formatting
       # Run prettier in check mode (doesn't modify files)
       run: npm run format:check
-      
+
     - name: Format instructions (if check fails)
       if: ${{ failure() }}
       run: |

.github/workflows/lint-and-build.yml .github/workflows/lint.yml.github/workflows/lint-and-build.yml renamed to .github/workflows/lint.yml

@@ -7,23 +7,17 @@ on:
     branches: [ main ]
 
 jobs:
-  prepare_matrix:
-    runs-on: ubuntu-latest
-    outputs:
-      versions: ${{ steps.generate-matrix.outputs.lts }}
-    steps:
-    - name: Select all current LTS versions of Node.js
-      id: generate-matrix
-      uses: msimerson/node-lts-versions@v1
+  node_matrix:
+    uses: appium/appium-workflows/.github/workflows/node-lts-matrix.yml@main
 
-  lint-and-build:
+  lint:
     runs-on: macos-latest
     needs:
-    - prepare_matrix
+    - node_matrix
     strategy:
       fail-fast: false
       matrix:
-        node-version: ${{ fromJSON(needs.prepare_matrix.outputs.versions) }}
+        node-version: ${{ fromJSON(needs.node_matrix.outputs.versions) }}
     steps:
     - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v3
     - name: Use Node.js ${{ matrix.node-version }}
@@ -32,9 +26,6 @@ jobs:
         node-version: ${{ matrix.node-version }}
     - name: Install dependencies
       run: npm install
-    
+
     - name: Lint
       run: npm run lint
-    
-    - name: Build
-      run: npm run build

.github/workflows/pr-title.yml

@@ -3,14 +3,8 @@ on:
   pull_request:
     types: [opened, edited, synchronize, reopened]
 
-
 jobs:
   lint:
-    name: https://www.conventionalcommits.org
-    runs-on: ubuntu-latest
-    steps:
-      - uses: beemojs/conventional-pr-action@v3
-        with:
-          config-preset: angular
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN  }}
+    uses: appium/appium-workflows/.github/workflows/pr-title.yml@main
+    with:
+      config-preset: angular

.github/workflows/test-validation.yml

@@ -7,23 +7,17 @@ on:
     branches: [ main ]
 
 jobs:
-  prepare_matrix:
-    runs-on: ubuntu-latest
-    outputs:
-      versions: ${{ steps.generate-matrix.outputs.lts }}
-    steps:
-    - name: Select all current LTS versions of Node.js
-      id: generate-matrix
-      uses: msimerson/node-lts-versions@v1
-  
+  node_matrix:
+    uses: appium/appium-workflows/.github/workflows/node-lts-matrix.yml@main
+
   validate-tests:
     runs-on: macos-latest
     needs:
-    - prepare_matrix
+    - node_matrix
     strategy:
       fail-fast: false
       matrix:
-        node-version: ${{ fromJSON(needs.prepare_matrix.outputs.versions) }}
+        node-version: ${{ fromJSON(needs.node_matrix.outputs.versions) }}
     steps:
     - uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v3
     - name: Use Node.js ${{ matrix.node-version }}
@@ -32,9 +26,9 @@ jobs:
         node-version: ${{ matrix.node-version }}
     - name: Install dependencies
       run: npm install
-    
+
     - name: Build project including tests
       run: npm run build
-    
+
     - name: Run unit tests
       run: npm run test:unit

.mocharc.cjs

@@ -0,0 +1,5 @@
+module.exports = {
+  require: ['tsx/cjs'],
+  'node-option': ['import=tsx'],
+  forbidOnly: Boolean(process.env.CI),
+};

.mocharc.json

@@ -614,12 +614,14 @@ export class AfcService {
       const localDstIsDirectory = await this._isLocalDirectory(localDstDir);
 
       if (!localDstIsDirectory) {
-        const stat = await fsp.stat(localDstDir).catch((err) => {
-          if (err.code === 'ENOENT') {
-            return null;
-          }
-          throw err;
-        });
+        const stat = await fsp
+          .stat(localDstDir)
+          .catch((err: NodeJS.ErrnoException): null => {
+            if (err.code === 'ENOENT') {
+              return null;
+            }
+            throw err;
+          });
         if (stat?.isFile()) {
           throw new Error(
             `Local destination exists and is a file, not a directory: ${localDstDir}`,

src/services/ios/afc/index.ts

@@ -130,7 +130,11 @@ describe('Apple TV Encryption - Opack2', () => {
     });
 
     it('should handle objects with undefined values', () => {
-      const obj = { a: 1, b: undefined, c: 3 };
+      const obj: { a: number; b: undefined; c: number } = {
+        a: 1,
+        b: undefined,
+        c: 3,
+      };
       const result = Opack2.dumps(obj);
       expect(result[0]).to.equal(0xe3);
     });

test/unit/apple-tv/encryption/opack2.spec.ts

@@ -1,36 +1,14 @@
 {
   "$schema": "https://json.schemastore.org/tsconfig",
+  "extends": "@appium/tsconfig/tsconfig.json",
   "compilerOptions": {
-    "module": "NodeNext",
-    "target": "es2022",
-    "preserveSymlinks": true,
-    "rootDir": "./",
-
     "strict": true,
-    "esModuleInterop": true,
-    "skipLibCheck": true,
-    "forceConsistentCasingInFileNames": true,
-
-    "outDir": "./build",
-    "declaration": true,
-    "declarationMap": true,
-    "removeComments": false,
-    "lib": ["es2023"],
-    "types": ["node", "mocha", "chai"],
-
-    "allowSyntheticDefaultImports": true,
-    "noImplicitAny": true,
-    "noImplicitThis": false,
-    "noUnusedParameters": false,
-    "verbatimModuleSyntax": true,
+    "strictNullChecks": false,
+    "outDir": "build",
+    "types": ["node", "mocha", "chai"]
   },
-
   "include": [
-    "./src/**/*.ts",
-    "./test/**/*.ts"
-  ],
-
-  "exclude": [
-    "node_modules",
+    "src",
+    "test"
   ]
-}
+}