Skip to content

add checks for lockfiles and formatting #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vgao1996 merged 1 commit into from
Dec 10, 2025
Merged

add checks for lockfiles and formatting #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/check-formatting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Check Formatting

on:
pull_request:
workflow_dispatch:

jobs:
check-formatting:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Use Node.js 22
uses: actions/setup-node@v4
with:
node-version: 22

- name: Check forklift formatting
working-directory: packages/forklift
run: |
npm ci
npm run format:check

- name: Check testsuite formatting
working-directory: packages/testsuite
run: |
npm ci
npm run format:check
36 changes: 36 additions & 0 deletions .github/workflows/check-lockfiles.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
name: Check Lockfiles

on:
pull_request:
workflow_dispatch:

jobs:
check-lockfiles:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Use Node.js 22
uses: actions/setup-node@v4
with:
node-version: 22

- name: Check forklift lockfile
working-directory: packages/forklift
run: |
npm install --package-lock-only --ignore-scripts
if ! git diff --exit-code package-lock.json; then
echo "Error: packages/forklift/package-lock.json is not up to date."
echo "Please run 'npm install' in packages/forklift and commit the changes."
exit 1
fi

- name: Check testsuite lockfile
working-directory: packages/testsuite
run: |
npm install --package-lock-only --ignore-scripts
if ! git diff --exit-code package-lock.json; then
echo "Error: packages/testsuite/package-lock.json is not up to date."
echo "Please run 'npm install' in packages/testsuite and commit the changes."
exit 1
fi
0 .github/workflows/ci.yml → .github/workflows/run-tests.yml
View file
Open in desktop
File renamed without changes.
4 changes: 4 additions & 0 deletions packages/testsuite/.prettierrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"tabWidth": 2,
"useTabs": false
}
17 changes: 17 additions & 0 deletions packages/testsuite/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions packages/testsuite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,15 @@
"version": "1.0.0",
"description": "Forklift testsuite",
"scripts": {
"test": "jest"
"test": "jest",
"format": "prettier --write \"src/**/*.ts\"",
"format:check": "prettier --check \"src/**/*.ts\""
},
"devDependencies": {
"forklift": "file:../forklift",
"@types/jest": "^29.5.14",
"forklift": "file:../forklift",
"jest": "^29.7.0",
"prettier": "^3.7.4",
"ts-jest": "^29.1.2",
"typescript": "^5.3.3"
}
Expand Down
50 changes: 25 additions & 25 deletions packages/testsuite/src/tests/publish_set_and_view_message.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,35 +2,35 @@ import { TestHarness, assertTxnSuccess } from "forklift";
import * as path from "path";

describe("publish, set message, and view message", () => {
let harness: TestHarness = new TestHarness();
let harness: TestHarness = new TestHarness();

it("publish package", () => {
const packageDir = path.join(__dirname, "../../move_packages/message");
const publishRes = harness.publishPackage({
profile: "default",
packageDir,
namedAddresses: {
simple_message: "default",
},
});
assertTxnSuccess(publishRes)
it("publish package", () => {
const packageDir = path.join(__dirname, "../../move_packages/message");
const publishRes = harness.publishPackage({
profile: "default",
packageDir,
namedAddresses: {
simple_message: "default",
},
});
assertTxnSuccess(publishRes);
});

const message = "Hello, Aptos!";
it("set message", () => {
const runRes = harness.runMoveFunction({
profile: "default",
functionId: `default::message::set_message`,
args: [`string:${message}`],
});
assertTxnSuccess(runRes);
const message = "Hello, Aptos!";
it("set message", () => {
const runRes = harness.runMoveFunction({
profile: "default",
functionId: `default::message::set_message`,
args: [`string:${message}`],
});
assertTxnSuccess(runRes);
});

it("view message", () => {
const viewRes = harness.runViewFunction({
functionId: `default::message::get_message`,
args: [`address:default`],
});
expect(viewRes.Result[0]).toBe(message);
it("view message", () => {
const viewRes = harness.runViewFunction({
functionId: `default::message::get_message`,
args: [`address:default`],
});
expect(viewRes.Result[0]).toBe(message);
});
});