refactor: remove autocomplete interaction parsing

Author: baptiste0928

CHANGELOG.md

@@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 - Upgraded to `twilight-model` 0.10.0
 
+### Removed
+- Autocomplete interactions parsing has been removed. See [#9](https://github.com/baptiste0928/twilight-interactions/issues/9).
+
 ## [0.9.1] - 2022-03-09
 ### Changed
 - Implemented `Attachment` command option type. (by @Lyssieth)

twilight-interactions-derive/src/command/model/command_model.rs

@@ -2,12 +2,9 @@ use proc_macro2::TokenStream;
 use quote::{quote, quote_spanned};
 use syn::{DeriveInput, FieldsNamed, Result};
 
-use crate::{
-    command::model::parse::{channel_type, command_option_value},
-    parse::find_attr,
-};
+use crate::command::model::parse::{channel_type, command_option_value};
 
-use super::parse::{FieldType, StructField, TypeAttribute};
+use super::parse::{FieldType, StructField};
 
 /// Implementation of CommandModel derive macro
 pub fn impl_command_model(input: DeriveInput, fields: Option<FieldsNamed>) -> Result<TokenStream> {
@@ -17,12 +14,7 @@ pub fn impl_command_model(input: DeriveInput, fields: Option<FieldsNamed>) -> Re
         None => Vec::new(),
     };
 
-    let partial = match find_attr(&input.attrs, "command") {
-        Some(attr) => TypeAttribute::parse(attr)?.partial,
-        None => false,
-    };
-
-    let field_unknown = field_unknown(partial);
+    let field_unknown = field_unknown();
     let fields_init = fields.iter().map(field_init);
     let fields_match_arms = fields.iter().map(field_match_arm);
     let fields_constructor = fields.iter().map(field_constructor);
@@ -108,18 +100,14 @@ fn field_constructor(field: &StructField) -> TokenStream {
 }
 
 /// Generate unknown field match arm
-fn field_unknown(partial: bool) -> TokenStream {
-    if partial {
-        quote!(continue)
-    } else {
-        quote! {
-            return ::std::result::Result::Err(
-                ::twilight_interactions::error::ParseError::Option(
-                    ::twilight_interactions::error::ParseOptionError {
-                        field: ::std::convert::From::from(other),
-                        kind: ::twilight_interactions::error::ParseOptionErrorType::UnknownField,
-                })
-            )
-        }
+fn field_unknown() -> TokenStream {
+    quote! {
+        return ::std::result::Result::Err(
+            ::twilight_interactions::error::ParseError::Option(
+                ::twilight_interactions::error::ParseOptionError {
+                    field: ::std::convert::From::from(other),
+                    kind: ::twilight_interactions::error::ParseOptionErrorType::UnknownField,
+            })
+        )
     }
 }

twilight-interactions-derive/src/command/model/create_command.rs

@@ -28,13 +28,6 @@ pub fn impl_create_command(input: DeriveInput, fields: Option<FieldsNamed>) -> R
         }
     };
 
-    if attributes.partial {
-        return Err(Error::new(
-            attr_span,
-            "Cannot implement `CreateCommand` on partial model",
-        ));
-    }
-
     let name = match &attributes.name {
         Some(name) => name,
         None => return Err(Error::new(attr_span, "Missing required attribute `name`")),

twilight-interactions-derive/src/command/model/parse.rs

@@ -66,8 +66,6 @@ pub struct TypeAttribute {
     pub name: Option<String>,
     /// Overwrite the field description
     pub desc: Option<String>,
-    /// Whether the type is partial
-    pub partial: bool,
     /// Whether the command should be enabled by default.
     pub default_permission: bool,
 }
@@ -76,15 +74,10 @@ impl TypeAttribute {
     /// Parse a single [`Attribute`]
     pub fn parse(attr: &Attribute) -> Result<Self> {
         let meta = attr.parse_meta()?;
-        let attrs = NamedAttrs::parse(meta, &["name", "desc", "partial", "default_permission"])?;
+        let attrs = NamedAttrs::parse(meta, &["name", "desc", "default_permission"])?;
 
         let name = attrs.get("name").map(parse_name).transpose()?;
         let desc = attrs.get("desc").map(parse_desc).transpose()?;
-        let partial = attrs
-            .get("partial")
-            .map(|v| v.parse_bool())
-            .transpose()?
-            .unwrap_or(false);
         let default_permission = attrs
             .get("default_permission")
             .map(|v| v.parse_bool())
@@ -94,7 +87,6 @@ impl TypeAttribute {
         Ok(Self {
             name,
             desc,
-            partial,
             default_permission,
         })
     }
@@ -107,7 +99,7 @@ pub struct FieldAttribute {
     pub rename: Option<String>,
     /// Overwrite the field description
     pub desc: Option<String>,
-    /// Whether the command supports autocomplete
+    /// Whether the field supports autocomplete
     pub autocomplete: bool,
     /// Limit to specific channel types
     pub channel_types: Vec<ChannelType>,

twilight-interactions/src/command/command_model.rs

@@ -58,11 +58,9 @@ use super::internal::CommandOptionData;
 /// that can be initialized from the command model.
 ///
 /// ### Autocomplete interactions
-/// When receiving an autocomplete interaction, you sometimes only care
-/// about a subset of received fields. You can use the
-/// `#[command(partial = true)]` attribute to ignore errors related to
-/// unknown fields. The [`CreateCommand`] trait cannot be applied on a
-/// partial model.
+/// Autocomplete interactions are no longer supported since 0.10, as the previous
+/// implementation was incorrect. See [#9](https://github.com/baptiste0928/twilight-interactions/issues/9)
+/// for more information.
 ///
 /// ## Subcommands and subcommands groups
 /// This trait also support parsing subcommands and subcommands group when
@@ -101,18 +99,16 @@ use super::internal::CommandOptionData;
 ///
 /// | Attribute                | Type           | Location             | Description                                                     |
 /// |--------------------------|----------------|----------------------|-----------------------------------------------------------------|
-/// | `partial`                | `bool`         | Type                 | Ignore unknown fields when parsing.                             |
 /// | `name`                   | `str`          | Variant (subcommand) | Subcommand name (required).                                     |
 /// | `rename`                 | `str`          | Field                | Use a different name for the field when parsing.                |
 /// | `channel_types`          | `str`          | Field                | Restricts the channel choice to specific types.[^channel_types] |
 /// | `max_value`, `min_value` | `i64` or `f64` | Field                | Maximum and/or minimum value permitted.                         |
 ///
 /// ### Example
 /// ```
-/// use twilight_interactions::command::{CommandModel, ResolvedUser};
+/// use twilight_interactions::command::CommandModel;
 ///
 /// #[derive(CommandModel)]
-/// #[command(partial = true)]
 /// struct HelloCommand {
 ///     #[command(rename = "text")]
 ///     message: String,