Creating Pom leaves ":" in artifactId leading to Maven issues

[jakestebbins]

In DepsModel the packaging is concatenated to the artifactID which causes issues with the maven pom spec "no strange symbols" seems to include colons.

I'm specifically hitting this issue when I'm using mvn dependency:tree e.g. [ERROR] 'dependencies.dependency.artifactId' for com.github.jnr:jffi:jar:native:jar with value 'jffi:jar:native' does not match a valid id pattern.

Is there a way to either concat this differently or possibly use the label in CreatePom.scala? https://maven.apache.org/ref/3.9.4/maven-model/maven.html#class_dependency

[johnynek]

I think you are seeing issues with encoding classifiers which may be not correctly supported.

If we research how classifiers should be encoded in XML then a change should be pretty easy (I can help you make a PR).

[jakestebbins]

That would be great, thanks so much!

Yeah was thinking of the "< classifier >" tag which looks like that info could already be contained in the MavenArtifactId? (either classifier or packaging)

[jakestebbins]

#358 is my attempt at fixing, idk why I couldn't get them to link