Skip to content

Commit d8f9e1c

Browse files
make code review fixes
1 parent c779415 commit d8f9e1c

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

metapool/plate.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
from datetime import datetime
44
import numpy as np
55
import pandas as pd
6+
import re
67
import warnings
78
from scipy.stats import zscore
89
from sklearn.linear_model import LogisticRegression
@@ -220,14 +221,13 @@ def _parse_and_validate_well_384(well):
220221
ValueError
221222
If well format is invalid or outside 384-well plate bounds.
222223
"""
223-
import re
224224

225225
VALID_384_WELL_ROWS = set('ABCDEFGHIJKLMNOP')
226226
MAX_384_WELL_COL = 24
227227

228228
# Check type and basic format using regex
229-
# Format: single letter A-Za-z followed by 1-2 digits
230-
if not isinstance(well, str) or not re.match(r'^[A-Za-z]\d{1,2}$', well):
229+
# Format: single letter A-Pa-p followed by 1-2 digits
230+
if not isinstance(well, str) or not re.match(r'^[A-Pa-p]\d{1,2}$', well):
231231
raise ValueError(
232232
"Well must be a letter A-P followed by a number 1-24, "
233233
"e.g., A1 or A01")

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
notebook = [
4141
'jupyter >= 1.1.1',
4242
'notebook >= 6.5.7',
43-
'watermark >= 2.5.0'
43+
'watermark >= 2.5.0',
4444
'ipyfilechooser']
4545

4646
all_deps = base + test + coverage + notebook

0 commit comments

Comments
 (0)