Skip to content

Commit 3ee9e0b

Browse files
committed
wip
1 parent fceeb77 commit 3ee9e0b

File tree

2 files changed

+1
-4
lines changed
  • data-migrator
    • core/src/main/java/io/camunda/migration/data/impl/history/migrator
    • qa/integration-tests/src/test/java/io/camunda/migration/data/qa/history/entity

2 files changed

+1
-4
lines changed

data-migrator/core/src/main/java/io/camunda/migration/data/impl/history/migrator/JobMigrator.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
import java.util.function.Consumer;
3131
import java.util.function.Function;
3232
import org.camunda.bpm.engine.history.HistoricJobLog;
33-
import org.camunda.bpm.engine.impl.jobexecutor.MessageJobDeclaration;
3433
import org.springframework.stereotype.Service;
3534

3635
/**
@@ -86,10 +85,10 @@ public Long migrateTransactionally(final HistoricJobLog c7JobLog) {
8685
final String c7JobId = c7JobLog.getJobId();
8786
if (shouldMigrate(c7JobId, HISTORY_JOB)) {
8887
String jobDefinitionConfiguration = c7JobLog.getJobDefinitionConfiguration();
88+
logMigratingJob(c7JobId);
8989
if (ASYNC_BEFORE.equals(jobDefinitionConfiguration) && ASYNC_AFTER.equals(jobDefinitionConfiguration)) {
9090
throw new EntitySkippedException(c7JobLog, SKIP_REASON_UNSUPPORTED_JOBS); //TODO test case for non-async jobs
9191
}
92-
logMigratingJob(c7JobId);
9392

9493
final var jobKey = getNextKey();
9594
final var builder = new JobDbModel.Builder().jobKey(jobKey);

data-migrator/qa/integration-tests/src/test/java/io/camunda/migration/data/qa/history/entity/HistoryJobTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,5 @@ public void shouldDeduplicateJobsByJobId() {
141141
List<JobEntity> c8Jobs = searchJobs(processInstances.getFirst().processInstanceKey());
142142
assertThat(c8Jobs).as("Exactly one C8 job per C7 job despite multiple log entries").hasSize(1);
143143

144-
// and: the job is tracked in the migration table by C7 job ID
145-
assertThat(dbClient.checkExistsByC7IdAndType(job.getId(), HISTORY_JOB)).isTrue();
146144
}
147145
}

0 commit comments

Comments
 (0)