Skip to content

Commit 3de30d4

Browse files
authored
Merge of #5951
2 parents fe0256b + 2aeadec commit 3de30d4

File tree

2 files changed

+0
-23
lines changed

2 files changed

+0
-23
lines changed

e2e/pvc.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -408,10 +408,6 @@ func checkPVSelectorValuesForPVC(f *framework.Framework, pvc *v1.PersistentVolum
408408
}
409409

410410
func getMetricsForPVC(f *framework.Framework, pvc *v1.PersistentVolumeClaim, t int) error {
411-
if k8sBrokenMetrics(f.ClientSet) {
412-
return nil
413-
}
414-
415411
kubelet, err := getKubeletIP(f.ClientSet)
416412
if err != nil {
417413
return err

e2e/utils.go

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1705,25 +1705,6 @@ func k8sVersionGreaterEquals(c kubernetes.Interface, major, minor int) bool {
17051705
return (vMajor > major) || (vMajor == major && vMinor >= minor)
17061706
}
17071707

1708-
var brokenMetrics *bool = nil
1709-
1710-
// k8sBrokenMetrics detects if Kubernetes 1.34 is used, this version has broken
1711-
// kube_volume_stats_* metrics:
1712-
// https://github.com/kubernetes/kubernetes/issues/133847
1713-
func k8sBrokenMetrics(c kubernetes.Interface) bool {
1714-
if brokenMetrics == nil {
1715-
broken := true
1716-
functional := true
1717-
if k8sVersionGreaterEquals(c, 1, 34) && !k8sVersionGreaterEquals(c, 1, 35) {
1718-
brokenMetrics = &broken
1719-
} else {
1720-
brokenMetrics = &functional
1721-
}
1722-
}
1723-
1724-
return *brokenMetrics
1725-
}
1726-
17271708
// waitForJobCompletion polls the status of the given job and waits until the
17281709
// jobs has succeeded or until the timeout is hit.
17291710
func waitForJobCompletion(c kubernetes.Interface, ns, job string, timeout int) error {

0 commit comments

Comments
 (0)