tetragon: Do proper error path cleanup in uprobeAttachExtra

olsajiri · kkourt · commit 34a1e874919f · 2026-02-06T14:40:29.000+01:00
We need to unpin the program in case the attach function fails.

Signed-off-by: Jiri Olsa &lt;jolsa@kernel.org&gt;
diff --git a/pkg/sensors/program/loader_linux.go b/pkg/sensors/program/loader_linux.go
@@ -439,7 +439,11 @@ func uprobeAttachExtra(load *Program, bpfDir string,
 		return nil, fmt.Errorf("pinning '%s' to '%s' failed: %w", load.Label, pinPath, err)
 	}
 
-	return attach(load, prog, spec, bpfDir, pin)
+	un, err := attach(load, prog, spec, bpfDir, pin)
+	if err != nil {
+		prog.Unpin()
+	}
+	return un, err
 }
 
 func uprobeAttach(load *Program, bpfDir string,

Original file line number	Diff line number	Diff line change
`@@ -439,7 +439,11 @@ func uprobeAttachExtra(load *Program, bpfDir string,`
`439`	`439`	`return nil, fmt.Errorf("pinning '%s' to '%s' failed: %w", load.Label, pinPath, err)`
`440`	`440`	`}`
`441`	`441`
`442`		`- return attach(load, prog, spec, bpfDir, pin)`
	`442`	`+ un, err := attach(load, prog, spec, bpfDir, pin)`
	`443`	`+ if err != nil {`
	`444`	`+ prog.Unpin()`
	`445`	`+ }`
	`446`	`+ return un, err`
`443`	`447`	`}`
`444`	`448`
`445`	`449`	`func uprobeAttach(load *Program, bpfDir string,`