Skip to content

Commit 3d462c5

Browse files
committed
Add some notes
1 parent 1cf15bc commit 3d462c5

File tree

3 files changed

+31
-4
lines changed

3 files changed

+31
-4
lines changed

.github/workflows/build-docker-image.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,15 @@
1-
name: Build Docker image
1+
name: Docker
2+
# This workflow builds the conda-store-ui docker image for each
3+
# pull request. This will ensure that no PR is breaking the docker
4+
# image, which will be built and pushed to GHCR when a new release
5+
# is cut.
26

37
on:
48
pull_request:
59

610
jobs:
711
build_docker_image:
8-
name: "Build Docker Images 🛠"
12+
name: "Build Docker Image 🛠"
913
runs-on: ubuntu-latest
1014
steps:
1115
- name: "Checkout Repository 🛎"
@@ -14,7 +18,7 @@ jobs:
1418
- name: "Set up Docker Buildx 🏗"
1519
uses: docker/setup-buildx-action@v3
1620

17-
- name: "Build Docker image 🚀"
21+
- name: "Build image 🚀"
1822
uses: docker/build-push-action@v5
1923
with:
2024
context: .

.github/workflows/release.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ jobs:
149149
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
150150

151151
build_and_push_docker_image:
152-
name: "Build Docker Images 🛠"
152+
name: "Push Docker Images 🛠"
153153
if: github.repository_owner == 'conda-incubator' && github.event_name == 'release' && startsWith(github.ref, 'refs/tags/')
154154
runs-on: ubuntu-latest
155155
needs: release-to-npmjs
@@ -178,6 +178,11 @@ jobs:
178178
with:
179179
images: |
180180
${{ env.GH_CONTAINER_REGISTRY }}/${{ env.IMAGE_NAME }}
181+
# ref: https://github.com/docker/metadata-action?tab=readme-ov-file#typeref
182+
# create tags for:
183+
# * the GH tag (eg. 2025.1.8)
184+
# * the branch (eg. main)
185+
# * the commit sha (eg. sha-860c190)
181186
tags: |
182187
type=ref,event=tag
183188
type=ref,event=branch
@@ -193,6 +198,7 @@ jobs:
193198
${{ steps.meta.outputs.tags }}
194199
push: true
195200
labels: ${{ steps.meta.outputs.labels }}
201+
# ref https://docs.docker.com/build/ci/github-actions/cache/
196202
cache-from: type=gha
197203
cache-to: type=gha,mode=max
198204

RELEASE.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
1. Create a new branch for the release `git checkout -b release-2024.9.1`
55
1. Clean the branch `git clean -fxdq`
66
1. Increment the version in `package.json` following our [version specification](https://conda.store/community/maintenance/release/#calver-details)
7+
8+
## Part 1: Build and release the npm package
79
1. Build the package locally:
810

911
```bash
@@ -35,6 +37,21 @@
3537

3638
If the dry run looks good, continue with the release checklist items.
3739

40+
## Part 2: Build and release the docker image
41+
42+
1. Build the docker image:
43+
44+
```bash
45+
docker build -t conda-incubator/conda-store-ui:<release version - eg. 2024.11.1> --target prod .
46+
```
47+
48+
2. Push the image to [GitHub's container registry](https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#pushing-container-images)
49+
50+
```bash
51+
# ensure you are authenticated with github
52+
docker push ghcr.io/conda-incubator/conda-store-ui:<release version - eg. 2024.11.1>
53+
```
54+
3855
## Troubleshooting notes
3956

4057
- If there are issues with the [GitHub Release UI](https://github.com/conda-incubator/conda-store-ui/releases/new), ensure that whatever code you published is checked into git, then tag and push both the commit and the tag:

0 commit comments

Comments
 (0)