fix: resolve TypeScript compilation errors in CI

- Fix type incompatibility between CachedSimulatorList interfaces
- Change lastUsed from string to Date type to match simulator-cache
- Simplify metadata objects to use only primitive types
- Add availability property to SimulatorFilters interface
- Fix metadata type constraints in response cache
- Remove unused imports and interfaces
- Replace non-null assertions with safe alternatives
- Fix all ESLint errors and warnings
- Update tests to use Date type for lastUsed property

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: conorluddy

src/tools/simctl/list.ts

@@ -1,5 +1,4 @@
-import { executeCommand, buildSimctlCommand } from '../../utils/command.js';
-import type { ToolResult, SimulatorList, OutputFormat } from '../../types/xcode.js';
+import type { OutputFormat } from '../../types/xcode.js';
 import { McpError, ErrorCode } from '@modelcontextprotocol/sdk/types.js';
 import { simulatorCache, type CachedSimulatorList } from '../../state/simulator-cache.js';
 import {
@@ -8,28 +7,28 @@ import {
   createProgressiveSimulatorResponse,
 } from '../../utils/response-cache.js';
 
-interface SimctlListToolArgs {
+interface SimctlListArgs {
   deviceType?: string;
   runtime?: string;
   availability?: 'available' | 'unavailable' | 'all';
   outputFormat?: OutputFormat;
   concise?: boolean;
 }
 
-export async function simctlListTool(args: any) {
+export async function simctlListTool(args: SimctlListArgs) {
   const {
     deviceType,
     runtime,
     availability = 'available',
     outputFormat = 'json',
     concise = true,
-  } = args as SimctlListToolArgs;
+  } = args;
 
   try {
     // Use the new caching system
     const cachedList = await simulatorCache.getSimulatorList();
 
-    let responseData: any;
+    let responseData: Record<string, unknown> | string;
 
     // Use progressive disclosure by default (concise=true)
     if (concise && outputFormat === 'json') {
@@ -46,8 +45,7 @@ export async function simctlListTool(args: any) {
         metadata: {
           totalDevices: summary.totalDevices,
           availableDevices: summary.availableDevices,
-          filters: { deviceType, runtime, availability },
-          summary,
+          hasFilters: !!(deviceType || runtime || availability !== 'available'),
         },
       });
 
@@ -117,16 +115,16 @@ function filterCachedSimulatorList(
   // Filter device types if specified
   if (filters.deviceType) {
     filtered.devicetypes = list.devicetypes.filter(dt =>
-      dt.name.toLowerCase().includes(filters.deviceType!.toLowerCase())
+      dt.name.toLowerCase().includes(filters.deviceType.toLowerCase())
     );
   }
 
   // Filter runtimes if specified
   if (filters.runtime) {
     filtered.runtimes = list.runtimes.filter(
       rt =>
-        rt.name.toLowerCase().includes(filters.runtime!.toLowerCase()) ||
-        rt.version.includes(filters.runtime!)
+        rt.name.toLowerCase().includes(filters.runtime.toLowerCase()) ||
+        rt.version.includes(filters.runtime)
     );
   }
 

src/tools/xcodebuild/build.ts

@@ -14,15 +14,8 @@ interface BuildToolArgs {
   derivedDataPath?: string;
 }
 
-export async function xcodebuildBuildTool(args: any) {
-  const {
-    projectPath,
-    scheme,
-    configuration = 'Debug',
-    destination,
-    sdk,
-    derivedDataPath,
-  } = args as BuildToolArgs;
+export async function xcodebuildBuildTool(args: BuildToolArgs) {
+  const { projectPath, scheme, configuration = 'Debug', destination, sdk, derivedDataPath } = args;
 
   try {
     // Validate inputs
@@ -90,11 +83,11 @@ export async function xcodebuildBuildTool(args: any) {
         destination: finalConfig.destination,
         sdk: finalConfig.sdk,
         duration,
-        summary,
-        smartDefaultsUsed: {
-          destination: !destination && smartDestination !== destination,
-          configuration: !args.configuration && finalConfig.configuration !== 'Debug',
-        },
+        success: summary.success,
+        errorCount: summary.errorCount,
+        warningCount: summary.warningCount,
+        smartDestinationUsed: !destination && smartDestination !== destination,
+        smartConfigurationUsed: !args.configuration && finalConfig.configuration !== 'Debug',
       },
     });
 
@@ -144,7 +137,9 @@ export async function xcodebuildBuildTool(args: any) {
   }
 }
 
-async function getSmartDestination(preferredConfig: any): Promise<string | undefined> {
+async function getSmartDestination(
+  preferredConfig: BuildConfig | null
+): Promise<string | undefined> {
   // If preferred config has a destination, use it
   if (preferredConfig?.destination) {
     return preferredConfig.destination;

src/utils/response-cache.ts

@@ -163,17 +163,16 @@ export function extractTestSummary(output: string, stderr: string, exitCode: num
   };
 }
 
+interface SimulatorDeviceForSummary {
+  isAvailable: boolean;
+  state: string;
+  name: string;
+  udid: string;
+  lastUsed?: Date;
+}
+
 interface CachedSimulatorList {
-  devices: Record<
-    string,
-    Array<{
-      isAvailable: boolean;
-      state: string;
-      name: string;
-      udid: string;
-      lastUsed?: string;
-    }>
-  >;
+  devices: Record<string, SimulatorDeviceForSummary[]>;
   lastUpdated: Date;
 }
 
@@ -211,12 +210,17 @@ export function extractSimulatorSummary(cachedList: CachedSimulatorList) {
     })),
     recentlyUsed: availableDevices
       .filter(d => d.lastUsed)
-      .sort((a, b) => new Date(b.lastUsed!).getTime() - new Date(a.lastUsed!).getTime())
+      .sort((a, b) => {
+        // We already filtered for devices with lastUsed
+        const aTime = a.lastUsed?.getTime() ?? 0;
+        const bTime = b.lastUsed?.getTime() ?? 0;
+        return bTime - aTime;
+      })
       .slice(0, 3)
       .map(d => ({
         name: d.name,
         udid: d.udid,
-        lastUsed: formatTimeAgo(d.lastUsed!),
+        lastUsed: formatTimeAgo(d.lastUsed || new Date()),
       })),
   };
 }
@@ -288,6 +292,7 @@ interface SimulatorSummary {
 interface SimulatorFilters {
   deviceType?: string;
   runtime?: string;
+  availability?: string;
 }
 
 export function createProgressiveSimulatorResponse(

tests/__tests__/utils/response-cache.test.ts

@@ -452,14 +452,14 @@ describe('extractSimulatorSummary', () => {
           udid: '123-456-789',
           state: 'Booted',
           isAvailable: true,
-          lastUsed: '2023-12-01T10:00:00Z',
+          lastUsed: new Date('2023-12-01T10:00:00Z'),
         },
         {
           name: 'iPhone 14',
           udid: '987-654-321',
           state: 'Shutdown',
           isAvailable: true,
-          lastUsed: '2023-12-01T09:00:00Z',
+          lastUsed: new Date('2023-12-01T09:00:00Z'),
         },
       ],
       'com.apple.CoreSimulator.SimRuntime.iOS-17-0': [