Rubocop: Rails/EnvironmentVariableAccess -> config files

Author: veganstraightedge

.rubocop.yml

@@ -27,11 +27,6 @@ Naming/VariableNumber:
   AllowedIdentifiers:
     - es_419
 
-# TODO: https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsenvironmentvariableaccess
-#       Consider using `Rails.application.config.foo` instead of `ENV['FOO']`
-Rails/EnvironmentVariableAccess:
-  Enabled: false
-
 RSpec/DescribeClass:
   Exclude:
     - spec/system/*

app/controllers/application_controller.rb

@@ -25,7 +25,7 @@ class ApplicationController < ActionController::Base
   helper :meta
 
   def staging?
-    ENV.fetch('ON_STAGING') { 'FALSE' } == 'TRUE'
+    Rails.application.config.x.app.on_staging
   end
   helper_method :staging?
 

app/lib/code_archiver.rb

@@ -34,7 +34,7 @@ def run
     end
 
     puts '*' * 80
-    if ENV.fetch('STATIC_EXPORT_IMAGES', nil).present?
+    if Rails.application.config.x.app.static_export_images
       puts 'downloading local copies of article images. this will take a while...'
       download_article_images
     else

app/lib/feature_flag.rb

@@ -52,7 +52,7 @@ def image side: :front, color: :color
     # Rails environment is production in our staging environment for
     # heroku reasons. We have environment variables set to distinguish
     # between the two.
-    throw e if Rails.env.production? && ENV.fetch('ON_PRODUCTION') { 'FALSE' } == 'TRUE'
+    throw e if Rails.env.production? && Rails.application.config.x.app.on_production
     ''
   end
 

app/models/concerns/single_page_tool.rb

@@ -111,5 +111,22 @@ class Application < Rails::Application
     # is deprecated and will be removed in Rails 8.2
     # To opt in to the new behavior, set `config.active_support.to_time_preserves_timezone = :zone`.
     config.active_support.to_time_preserves_timezone = :zone
+
+    # Load each service specific config file into the application's config,
+    # using Rails' custom config namespace: x
+    # Example: Rails.application.config.x.stripe.secret_key
+    #
+    # Enumerate through all YAML files in config/services
+    Rails.root.glob('config/services/*.yml').each do |yaml_filepath|
+      # Read the service name from the YAML file's name
+      service_name = File.basename(yaml_filepath, '.yml')
+
+      # Read the YAML config file for this service
+      service_config = config_for("services/#{service_name}")
+
+      # Load the service's configuration into the custom config namespace
+      # Example: when `yaml_filepath` is "stripe.yml", this will call `config.x.stripe =`
+      config.x.public_send(:"#{service_name}=", service_config)
+    end
   end
 end

config/application.rb

@@ -1,11 +1,11 @@
 Bugsnag.configure do |config|
-  config.api_key = ENV.fetch('BUGSNAG_API_KEY', nil)
+  config.api_key = Rails.application.config.x.bugsnag.api_key
   config.notify_release_stages = %w[staging production]
 
   # we consider both staging and production as 'production' for heroku
   # reasons, so set based on ENV variables
   if Rails.env.production?
-    staging = ENV.fetch('ON_STAGING') { 'FALSE' } == 'TRUE'
+    staging = Rails.application.config.x.app.on_staging
     config.release_stage = staging ? 'staging' : 'production'
   else
     # otherwise it is 'test' or 'development'

config/initializers/bugsnag.rb

@@ -4,8 +4,8 @@ class Attack
       throttle('limit requests per IP', limit: 60, period: 1.minute) do |req|
         # Allow trusted requests through unthrottled
         trusted_request =
-          ENV.fetch('RACK_ATTACK_ALLOWED_USER_AGENT', nil).present? &&
-          req.user_agent&.starts_with?(ENV.fetch('RACK_ATTACK_ALLOWED_USER_AGENT'))
+          Rails.application.config.x.rack_attack.allowed_user_agent.present? &&
+          req.user_agent&.starts_with?(Rails.application.config.x.rack_attack.allowed_user_agent)
 
         # Allow Asset Pipeline and ActiveStorage requests through unthrottled
         asset_pipeline = req.path.start_with? '/assets'

config/initializers/rack_attack.rb

@@ -1,6 +1,6 @@
 SIDEKIQ_REDIS_CONFIGURATION = {
   # use REDIS_PROVIDER for Redis environment variable name, defaulting to REDIS_URL
-  url:        ENV.fetch(ENV.fetch('REDIS_PROVIDER', 'REDIS_URL'), nil),
+  url:        Rails.application.config.x.redis.url,
   ssl_params: { verify_mode: OpenSSL::SSL::VERIFY_NONE }
 }.freeze
 

config/initializers/sidekiq.rb

@@ -1,8 +1,8 @@
 Rails.configuration.stripe = {
-  publishable_key: ENV.fetch('STRIPE_PUBLISHABLE_KEY', nil),
-  secret_key:      ENV.fetch('STRIPE_SECRET_KEY', nil)
+  publishable_key: Rails.application.config.x.stripe.publishable_key,
+  secret_key:      Rails.application.config.x.stripe.secret_key
 }
 
 Stripe.api_key = Rails.configuration.stripe[:secret_key]
 
-STRIPE_MONTHLY_PRICE_ID = ENV.fetch('STRIPE_MONTHLY_PRICE_ID') { 'monthly' }
+STRIPE_MONTHLY_PRICE_ID = Rails.application.config.x.stripe.monthly_price_id