Skip to content

Commit 7f618f4

Browse files
Languages
1 parent 5391778 commit 7f618f4

File tree

2 files changed

+30
-16
lines changed

2 files changed

+30
-16
lines changed

app/controllers/sitemap_controller.rb

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,10 @@ def show
4646
# To Change Everything (TCE)
4747
@to_change_everything_languages = TO_CHANGE_EVERYTHING_LANGUAGES
4848

49+
# languages
50+
@locales = languages
51+
4952
# TODO: extract to show view + _url partial
50-
# add_languages
5153
# add_tools
5254
end
5355

@@ -89,20 +91,13 @@ def add_tools
8991
end
9092

9193
# languages
92-
def add_languages
93-
language_url = [root_url, :languages].join '/'
94-
@urls << sitemap_url.new(language_url, @last_modified)
95-
94+
def languages
9695
Locale.live.each do |locale|
9796
unicode_url = language_url locale: locale.name.downcase.tr(' ', '-')
9897
slug_url = language_url locale: locale.slug.to_sym
9998
english_url = language_url locale: locale.name_in_english.downcase.tr(' ', '-')
10099

101-
urls = [unicode_url, slug_url, english_url].uniq
102-
103-
urls.each do |url|
104-
@urls << sitemap_url.new(url, @last_modified)
105-
end
100+
[unicode_url, slug_url, english_url].uniq
106101
end
107102
end
108103

app/views/sitemap/show.xml.erb

Lines changed: 25 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,31 @@
88
xmlns:pagemap='http://www.google.com/schemas/sitemap-pagemap/1.0'
99
xmlns:xhtml='http://www.w3.org/1999/xhtml'
1010
xsi:schemaLocation='http://www.sitemaps.org/schemas/sitemap/0.9 http://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd'>
11+
<%# @urls.each do |url| %>
12+
<%#= render 'sitemap/url', loc: url.loc, lastmod: url.lastmod %>
13+
<%# end %>
14+
15+
<%# language pages %>
16+
<%= render 'sitemap/url', loc: languages_url, lastmod: @last_modified %>
17+
18+
<% Locale.live.each do |locale| %>
19+
<%
20+
unicode_url = language_url locale: locale.name.downcase.tr(' ', '-')
21+
slug_url = language_url locale: locale.slug.to_sym
22+
english_url = language_url locale: locale.name_in_english.downcase.tr(' ', '-')
23+
24+
urls = [unicode_url, slug_url, english_url].uniq
25+
%>
26+
27+
<% urls.each do |url| %>
28+
<%= render 'sitemap/url', loc: url, lastmod: @last_modified %>
29+
<% end %>
30+
<% end %>
31+
32+
33+
34+
<% if false %>
35+
1136

1237
<%= cache @last_modified do %>
1338
<%# homepage %>
@@ -69,11 +94,5 @@
6994
<% end %>
7095

7196

72-
<% if false %>
73-
74-
<%# @urls.each do |url| %>
75-
<%#= render 'sitemap/url', loc: url.loc, lastmod: url.lastmod %>
76-
<%# end %>
77-
7897
<% end %>
7998
</urlset>

0 commit comments

Comments
 (0)