Skip to content

Fix: Add nil check for SubjectRef before accessing its Kind in contact group membership controllers. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoseSzycho merged 1 commit into from
Jan 15, 2026
Merged

Fix: Add nil check for SubjectRef before accessing its Kind in contact group membership controllers. #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/controller/contactgroupmembership_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ func (r *ContactGroupMembershipController) Reconcile(ctx context.Context, req ct
}

// Set Status.Username based on Contact.Spec.SubjectRef.Kind
if contact.Spec.SubjectRef.Kind == "User" {
if contact.Spec.SubjectRef != nil && contact.Spec.SubjectRef.Kind == "User" {
contactGroupMembership.Status.Username = contact.Spec.SubjectRef.Name
}

Expand Down
2 changes: 1 addition & 1 deletion internal/controller/contactgroupmembershipremoval_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func (r *ContactGroupMembershipRemovalController) Reconcile(ctx context.Context,
}

// Set Status.Username based on Contact.Spec.SubjectRef.Kind
if contact.Spec.SubjectRef.Kind == "User" {
if contact.Spec.SubjectRef != nil && contact.Spec.SubjectRef.Kind == "User" {
cgmr.Status.Username = contact.Spec.SubjectRef.Name
}

Expand Down