Discontinue help action and shortcut (#2664)

Fixes #1475

Other elementary core apps do not implement a help action with F1 shortcut (although many third-party apps do). Pending implementation of a consistent pattern for help/info across elementary core apps this PR removes the F1 shortcut and action from Files.

Author: jeremypw

libcore/Resources.vala

@@ -20,7 +20,6 @@ namespace Files {
     public const string APP_ID = "io.elementary.files";
     public const string APP_DESKTOP = APP_ID + ".desktop";
     public const string APP_TITLE = N_("Files");
-    public const string HELP_URL = "https://elementaryos.stackexchange.com/questions/tagged/pantheon-files";
     public const string BUG_URL = "https://github.com/elementary/files/issues/new";
     public const string INVALID_TAB_NAME = "----";
 

src/View/Window.vala

@@ -35,7 +35,6 @@ public class Files.View.Window : Hdy.ApplicationWindow {
         {"tab", action_tab, "s"},
         {"go-to", action_go_to, "s"},
         {"zoom", action_zoom, "s"},
-        {"info", action_info, "s"},
         {"view-mode", action_view_mode, "u", "0" },
         {"show-hidden", null, null, "false", change_state_show_hidden},
         {"singleclick-select", null, null, "false", change_state_single_click_select},
@@ -163,7 +162,6 @@ public class Files.View.Window : Hdy.ApplicationWindow {
             marlin_app.set_accels_for_action ("win.go-to::UP", {"<Alt>Up"});
             marlin_app.set_accels_for_action ("win.forward(1)", {"<Alt>Right", "XF86Forward"});
             marlin_app.set_accels_for_action ("win.back(1)", {"<Alt>Left", "XF86Back"});
-            marlin_app.set_accels_for_action ("win.info::HELP", {"F1"});
             marlin_app.set_accels_for_action ("win.tab::TAB", {"<Shift><Ctrl>K"});
             marlin_app.set_accels_for_action ("win.tab::WINDOW", {"<Ctrl><Alt>N"});
             marlin_app.set_accels_for_action ("win.focus-sidebar", {"<Ctrl>Left"});
@@ -1014,16 +1012,7 @@ public class Files.View.Window : Hdy.ApplicationWindow {
         }
     }
 
-    private void action_info (GLib.SimpleAction action, GLib.Variant? param) {
-        switch (param.get_string ()) {
-            case "HELP":
-                show_app_help ();
-                break;
 
-            default:
-                break;
-        }
-    }
 
     private void action_undo (GLib.SimpleAction action, GLib.Variant? param) {
         if (doing_undo_redo) { /* Guard against rapid pressing of Ctrl-Z */
@@ -1126,15 +1115,6 @@ public class Files.View.Window : Hdy.ApplicationWindow {
         dialog.present ();
     }
 
-    void show_app_help () {
-        AppInfo.launch_default_for_uri_async.begin (Files.HELP_URL, null, null, (obj, res) => {
-            try {
-                AppInfo.launch_default_for_uri_async.end (res);
-            } catch (Error e) {
-                warning ("Could not open help: %s", e.message);
-            }
-        });
-    }
 
     public GLib.SimpleAction? get_action (string action_name) {
         return (GLib.SimpleAction?)(lookup_action (action_name));