fix: resolve golangci-lint issues in timeout feature

- Fix gofmt formatting in root.go, utils.go, utils_test.go
- Fix empty-block revive issue in utils.go by inverting condition

Author: natsirtguy

cmd/mcptools/commands/root.go

@@ -9,18 +9,18 @@ import (
 
 // flags.
 const (
-	FlagFormat         = "--format"
-	FlagFormatShort    = "-f"
-	FlagParams         = "--params"
-	FlagParamsShort    = "-p"
-	FlagHelp           = "--help"
-	FlagHelpShort      = "-h"
-	FlagServerLogs     = "--server-logs"
-	FlagTransport      = "--transport"
-	FlagAuthUser       = "--auth-user"
-	FlagAuthHeader     = "--auth-header"
-	FlagTimeout        = "--timeout"
-	FlagTimeoutShort   = "-t"
+	FlagFormat       = "--format"
+	FlagFormatShort  = "-f"
+	FlagParams       = "--params"
+	FlagParamsShort  = "-p"
+	FlagHelp         = "--help"
+	FlagHelpShort    = "-h"
+	FlagServerLogs   = "--server-logs"
+	FlagTransport    = "--transport"
+	FlagAuthUser     = "--auth-user"
+	FlagAuthHeader   = "--auth-header"
+	FlagTimeout      = "--timeout"
+	FlagTimeoutShort = "-t"
 )
 
 // entity types.

cmd/mcptools/commands/utils.go

@@ -34,56 +34,55 @@ func IsHTTP(str string) bool {
 // It returns the header value and a cleaned URL (with embedded credentials removed).
 func buildAuthHeader(originalURL string) (string, string, error) {
 	cleanURL := originalURL
-	
+
 	// First, check if we have explicit auth-user flag with username:password format
 	if AuthUser != "" {
 		// Parse username:password format
 		if !strings.Contains(AuthUser, ":") {
 			return "", originalURL, fmt.Errorf("auth-user must be in username:password format (missing colon)")
 		}
-		
+
 		parts := strings.SplitN(AuthUser, ":", 2)
 		username := parts[0]
 		password := parts[1]
-		
+
 		// Allow empty username or password, but not both
-		if username == "" && password == "" {
-			// Both empty, treat as no auth
-		} else {
+		if username != "" || password != "" {
 			// Create basic auth header
 			auth := base64.StdEncoding.EncodeToString([]byte(username + ":" + password))
 			header := "Basic " + auth
 			return header, cleanURL, nil
 		}
+		// Both empty, treat as no auth - fall through
 	}
-	
+
 	// Check for custom auth header
 	if AuthHeader != "" {
 		return AuthHeader, cleanURL, nil
 	}
-	
+
 	// Extract credentials from URL if embedded
 	parsedURL, err := url.Parse(originalURL)
 	if err != nil {
 		return "", originalURL, err
 	}
-	
+
 	if parsedURL.User != nil {
 		username := parsedURL.User.Username()
 		password, _ := parsedURL.User.Password()
-		
+
 		if username != "" {
 			// Create basic auth header
 			auth := base64.StdEncoding.EncodeToString([]byte(username + ":" + password))
-			
+
 			// Clean the URL by removing user info
 			parsedURL.User = nil
 			cleanURL = parsedURL.String()
-			
+
 			return "Basic " + auth, cleanURL, nil
 		}
 	}
-	
+
 	return "", cleanURL, nil
 }
 

cmd/mcptools/commands/utils_test.go

@@ -191,7 +191,6 @@ nested  {"key":"value"}`[1:] // remove first newline
 	}
 }
 
-
 func TestProcessFlagsTimeout(t *testing.T) {
 	originalTimeout := InitTimeout
 	defer func() { InitTimeout = originalTimeout }()