Fix FieldsBelowInit and KotlinGenericsCast: Move properties above init block #55357
+27
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
mdvacca
force-pushed
the
export-D91731938
branch
from
a81d387 to
bbe4541
Compare
facebook-github-bot
added
the
Shared with Meta
mdvacca
force-pushed
the
export-D91731938
branch
from
bbe4541 to
55e62b5
Compare
cortinico
approved these changes
Jan 29, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary: **Lint Issue:** ANDROIDLINT FieldsBelowInit warning on line 347. The `nativeModules` property was declared below the init block. The lint warns that fields declared after init blocks can lead to initialization order issues in Kotlin, where the field might not be available during the init block execution. **Fix:** Moved the `nativeModules` computed property declaration to before the init block, alongside other property declarations. Since this is a computed property (getter only), there's no actual initialization order issue, but placing it before the init block follows Kotlin best practices and avoids confusion. Differential Revision: D91709480
Summary: **Lint Issue:** ANDROIDLINT FieldsBelowInit warning on line 480. The `eventDispatcher` property was declared below the init block. The lint warns that fields declared after init blocks can lead to initialization order issues in Kotlin, where the field might not be available during the init block execution. **Fix:** Moved the `eventDispatcher` computed property declaration to before the init block, alongside other property declarations. Since this is a computed property (getter only) that returns `fabricUIManager.eventDispatcher`, there's no actual initialization order issue, but placing it before the init block follows Kotlin best practices and avoids confusion. Differential Revision: D91709482
Summary:
**Lint Issue:** ANDROIDLINT KotlinGenericsCast warning on line 361.
The `getNativeModule` function casts `turboModuleManager.getModule(nativeModuleName)` to generic type `T?`. The lint warns that casts to erased Kotlin generic type references are only checked at compile time, and at runtime, casts to type arguments of a generic function are unchecked due to type erasure.
**Fix:** Added `SuppressLint("KotlinGenericsCast")` annotation to the function. The existing `Suppress("UNCHECKED_CAST")` only suppresses the Kotlin compiler warning, not the AndroidLint warning. This cast is intentional and unavoidable given the API design where callers specify the expected return type.
Differential Revision: D91709481
Summary: Fixed EmptyCatchBlock lint error in BridgelessAtomicRef.kt. Added a comment explaining that the InterruptedException is intentionally caught to record the interrupt status, which is then restored after the wait loop completes. This is a standard pattern for proper interrupt handling. changelog: [internal] internal Differential Revision: D91728772
cortinico
approved these changes
Jan 29, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary: Fixed UnsafeDereference lint errors in BridgelessCatalystInstance.kt. Replaced unsafe !! operator with requireNotNull() for: - javaScriptContextHolder - jsCallInvokerHolder - reactQueueConfiguration This provides better error messages when null values are encountered. changelog: [internal] internal Differential Revision: D91731458
…t block Summary: Fixed FieldsBelowInit lint errors in BridgelessReactContext.kt. Moved property declarations (devSupportManager, defaultHardwareBackBtnHandler) above the init block to ensure proper initialization order. Also added Suppress for KotlinGenericsCast warning on the generic cast that is necessary for the proxy implementation. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91731938
mdvacca
force-pushed
the
export-D91731938
branch
from
55e62b5 to
57befce
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…t block (facebook#55357) Summary: Fixed FieldsBelowInit lint errors in BridgelessReactContext.kt. Moved property declarations (devSupportManager, defaultHardwareBackBtnHandler) above the init block to ensure proper initialization order. Also added Suppress for KotlinGenericsCast warning on the generic cast that is necessary for the proxy implementation. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91731938
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…t block (facebook#55357) Summary: Fixed FieldsBelowInit lint errors in BridgelessReactContext.kt. Moved property declarations (devSupportManager, defaultHardwareBackBtnHandler) above the init block to ensure proper initialization order. Also added Suppress for KotlinGenericsCast warning on the generic cast that is necessary for the proxy implementation. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91731938
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 29, 2026
…t block (facebook#55357) Summary: Fixed FieldsBelowInit lint errors in BridgelessReactContext.kt. Moved property declarations (devSupportManager, defaultHardwareBackBtnHandler) above the init block to ensure proper initialization order. Also added Suppress for KotlinGenericsCast warning on the generic cast that is necessary for the proxy implementation. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D91731938
|
This pull request has been merged in c9d1e05. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed FieldsBelowInit lint errors in BridgelessReactContext.kt.
Moved property declarations (devSupportManager, defaultHardwareBackBtnHandler) above the init block to ensure proper initialization order.
Also added Suppress for KotlinGenericsCast warning on the generic cast that is necessary for the proxy implementation.
changelog: [internal] internal
Reviewed By: cortinico
Differential Revision: D91731938