Skip to content

Commit 62987d7

Browse files
mcfifacebook-github-bot
authored andcommitted
Accelerating fbthrift Builds by Skipping Folly Tests in Dependency Compilation
Summary: fbthrift relies on folly, which by default builds all tests—significantly slowing down the process. This update separates the builds for fbthrift dependencies and fbthrift itself. By passing --no-tests to the dedicated dependencies build, folly tests are skipped, reducing about two-thirds of folly's build targets and noticeably accelerating the fbthrift build. Reviewed By: YifanYuan3 Differential Revision: D91095879
1 parent c333a67 commit 62987d7

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

packages/wdl_bench/install_wdl_bench.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,8 +181,9 @@ build_fbthrift()
181181
./build/fbcode_builder/getdeps.py install-system-deps --recursive fbthrift
182182
echo "Building fbthrift with $(get_march_for_host)"
183183
MARCH="$(get_march_for_host)"
184-
EXTRA_DEFINES=$(printf '{"enable_tests": "1", "CMAKE_C_FLAGS":"%s","CMAKE_CXX_FLAGS":"%s"}' "$MARCH" "$MARCH")
185-
python3 ./build/fbcode_builder/getdeps.py --allow-system-packages build fbthrift --src-dir "." --scratch-path "${WDL_BUILD}" --extra-cmake-defines="$EXTRA_DEFINES"
184+
EXTRA_DEFINES=$(printf '{"CMAKE_C_FLAGS":"%s","CMAKE_CXX_FLAGS":"%s"}' "$MARCH" "$MARCH")
185+
python3 ./build/fbcode_builder/getdeps.py --allow-system-packages build fbthrift --src-dir "." --scratch-path "${WDL_BUILD}" --extra-cmake-defines="$EXTRA_DEFINES" --only-deps --no-tests
186+
python3 ./build/fbcode_builder/getdeps.py --allow-system-packages build fbthrift --src-dir "." --scratch-path "${WDL_BUILD}" --extra-cmake-defines="$EXTRA_DEFINES" --no-deps
186187
for benchmark in $fbthrift_benchmark_list; do
187188
cp "$WDL_BUILD/build/fbthrift/bin/$benchmark" "$WDL_ROOT/$benchmark"
188189
done

0 commit comments

Comments
 (0)