Bump the github-actions group with 5 updates (#178)

dependabot[bot] · sanketsudake · Copilot · web-flow · commit 1bce5f82a643 · 2025-05-29T14:47:00.000+05:30
* Bump the github-actions group with 5 updates Bumps the github-actions group with 5 updates: | Package | From | To | | --- | --- | --- | | [actions/checkout](https://github.com/actions/checkout) | `4.1.7` | `4.2.2` | | [github/codeql-action](https://github.com/github/codeql-action) | `3.25.10` | `3.28.18` | | [actions/setup-go](https://github.com/actions/setup-go) | `5.0.1` | `5.5.0` | | [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) | `6.0.1` | `8.0.0` | | [ko-build/setup-ko](https://github.com/ko-build/setup-ko) | `0.7` | `0.9` | Updates `actions/checkout` from 4.1.7 to 4.2.2 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@692973e...11bd719) Updates `github/codeql-action` from 3.25.10 to 3.28.18 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@23acc5c...ff0a06e) Updates `actions/setup-go` from 5.0.1 to 5.5.0 - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@cdcb360...d35c59a) Updates `golangci/golangci-lint-action` from 6.0.1 to 8.0.0 - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@a4f60bb...4afd733) Updates `ko-build/setup-ko` from 0.7 to 0.9 - [Release notes](https://github.com/ko-build/setup-ko/releases) - [Commits](ko-build/setup-ko@3aebd05...d006021) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 4.2.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: github/codeql-action dependency-version: 3.28.18 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: actions/setup-go dependency-version: 5.5.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: golangci/golangci-lint-action dependency-version: 8.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions - dependency-name: ko-build/setup-ko dependency-version: '0.9' dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> * Update golangci-lint Signed-off-by: Sanket Sudake <sanketsudake@gmail.com> * Update golangci-lint version Signed-off-by: Sanket Sudake <sanketsudake@gmail.com> * update kafka deployment Signed-off-by: Sanket Sudake <sanketsudake@gmail.com> * Update gcp-pubsub-http-connector/main.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * update go version 1.24.3 Signed-off-by: Sanket Sudake <sanketsudake@gmail.com> * update dependabot yml Signed-off-by: Sanket Sudake <sanketsudake@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Sanket Sudake <sanketsudake@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sanket Sudake <sanketsudake@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -3,7 +3,7 @@ updates:
   - package-ecosystem: github-actions
     directory: /
     schedule:
-      interval: weekly
+      interval: monthly
     open-pull-requests-limit: 5
     groups:
       github-actions:
@@ -13,7 +13,7 @@ updates:
   - package-ecosystem: gomod
     directory: /
     schedule:
-      interval: weekly
+      interval: monthly
     open-pull-requests-limit: 5
     groups:
       go-dependencies:
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -7,14 +7,18 @@ on:
     branches:
       - main
 
+concurrency:
+  group: integration-test-${{ github.ref }}
+  cancel-in-progress: true
+  
 jobs:
   check:
     runs-on: ubuntu-latest
     outputs:
       packages: ${{ steps.filter.outputs.changes }}
     steps:
       - name: Check out code
-        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
       - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: filter
@@ -39,28 +43,27 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out code
-        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
       - name: Setup Keda
         uses: ./.github/actions/setup-keda
 
       - name: Deploy Kafka Cluster
         run: |
           kubectl create namespace kafka
-          curl -L http://strimzi.io/install/latest | sed 's/namespace: .*/namespace: kafka/' | kubectl create -f - -n kafka
+          kubectl create -f 'https://strimzi.io/install/latest?namespace=kafka' -n kafka
+          kubectl rollout status deployment strimzi-cluster-operator -n kafka --timeout=120s
           sleep 10s
-          kubectl create -f kafka-http-connector/test/kubernetes/kafka-cluster.yaml
+          kubectl create -f kafka-http-connector/test/kubernetes/kafka-cluster.yaml -n kafka
           echo "Kafka Cluster is getting up."
-          kubectl wait -f kafka-http-connector/test/kubernetes/kafka-cluster.yaml --for=condition=ready --timeout=-1s -n kafka
-          sleep 10s
+          kubectl wait kafka/my-cluster-test --for=condition=ready --timeout=300s -n kafka
           kubectl get pods -n kafka
-          kubectl wait pod -l app.kubernetes.io/name=zookeeper --for=condition=ready --timeout=-1s -n kafka
 
       - name: Create Kafka topics
         run: |
-          kubectl apply -f kafka-http-connector/test/kubernetes/kafka-req-topic.yaml
-          kubectl apply -f kafka-http-connector/test/kubernetes/kafka-err-topic.yaml
-          kubectl apply -f kafka-http-connector/test/kubernetes/kafka-res-topic.yaml
+          kubectl apply -f kafka-http-connector/test/kubernetes/kafka-req-topic.yaml -n kafka
+          kubectl apply -f kafka-http-connector/test/kubernetes/kafka-err-topic.yaml -n kafka
+          kubectl apply -f kafka-http-connector/test/kubernetes/kafka-res-topic.yaml -n kafka
 
       - name: Deploy Kafka Keda Connector and Keda ScaledObject
         run: |
@@ -90,7 +93,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out code
-        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
       - name: Setup Keda
         uses: ./.github/actions/setup-keda
@@ -134,7 +137,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out code
-        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
       - name: Setup Keda
         uses: ./.github/actions/setup-keda
@@ -170,7 +173,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out code
-        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
       - name: Setup Keda
         uses: ./.github/actions/setup-keda
@@ -219,7 +222,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out code
-        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
       - name: Setup Keda
         uses: ./.github/actions/setup-keda
@@ -264,7 +267,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check out code
-        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
       - name: Setup Keda
         uses: ./.github/actions/setup-keda
diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
@@ -20,6 +20,10 @@ on:
   schedule:
     - cron: '43 18 * * 1'
 
+concurrency:
+  group: codeql-analysis-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   analyze:
     name: Analyze
@@ -39,11 +43,11 @@ jobs:
 
     steps:
     - name: Check out code
-      uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL
-      uses: github/codeql-action/init@23acc5c183826b7a8a97bce3cecc52db901f8251 # v3.25.10
+      uses: github/codeql-action/init@ff0a06e83cb2de871e5a09832bc6a81e7276941f # v3.28.18
       with:
         languages: ${{ matrix.language }}
         # If you wish to specify custom queries, you can do so here or in a config file.
@@ -54,7 +58,7 @@ jobs:
     # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
     # If this step fails, then you should remove it and run the build manually (see below)
     - name: Autobuild
-      uses: github/codeql-action/autobuild@23acc5c183826b7a8a97bce3cecc52db901f8251 # v3.25.10
+      uses: github/codeql-action/autobuild@ff0a06e83cb2de871e5a09832bc6a81e7276941f # v3.28.18
 
     # ℹ️ Command-line programs to run using the OS shell.
     # 📚 https://git.io/JvXDl
@@ -68,4 +72,4 @@ jobs:
     #   make release
 
     - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@23acc5c183826b7a8a97bce3cecc52db901f8251 # v3.25.10
+      uses: github/codeql-action/analyze@ff0a06e83cb2de871e5a09832bc6a81e7276941f # v3.28.18
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -10,19 +10,23 @@ on:
   workflow_dispatch:
 
 env:
-  GOLANGCI_LINT_VERSION: v1.61.0
-  GOLANGCI_LINT_TIMEOUT: 5m
+  GOLANGCI_LINT_VERSION: v2.1.6
+  GOLANGCI_LINT_TIMEOUT: 10m
+
+concurrency:
+  group: lint-${{ github.ref }}
+  cancel-in-progress: true
 
 jobs:
   lint:
     runs-on: ubuntu-latest
 
     steps:
       - name: Check out code
-        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
       - name: Set up Go
-        uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
+        uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
         with:
           go-version-file: "go.mod"
           cache: true
@@ -33,7 +37,7 @@ jobs:
           go mod download
 
       - name: Run golangci-lint
-        uses: golangci/golangci-lint-action@a4f60bb28d35aeee14e6880718e0c85ff1882e64 # v6.0.1
+        uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0
         with:
           version: ${{ env.GOLANGCI_LINT_VERSION }}
           args: --timeout=${{ env.GOLANGCI_LINT_TIMEOUT }}
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -14,7 +14,7 @@ jobs:
       packages: ${{ steps.filter.outputs.changes }}
     steps:
       - name: Check out code
-        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
       - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
         id: filter
@@ -45,10 +45,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout sources
-        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
       - name: Set up Go
-        uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
+        uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
         with:
           go-version-file: "go.mod"
           cache: true
@@ -57,7 +57,7 @@ jobs:
         run: cd ${{ matrix.run }}; version=$(cat version);echo "version=$version" >> $GITHUB_ENV
 
       - name: Setup Ko
-        uses: ko-build/setup-ko@3aebd0597dc1e9d1a26bcfdb7cbeb19c131d3037 # v0.7
+        uses: ko-build/setup-ko@d006021bd0c28d1ce33a07e7943d48b079944c8d # v0.9
 
       - name: Build
         shell: bash
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -1,32 +1,42 @@
+version: "2"
 linters:
   enable:
-    - errcheck
-    - gosimple
-    - govet
-    - ineffassign
-    - staticcheck
-    - typecheck
-    - unused
-    # Additional linters
-    - gofmt
-    - goimports
-    - misspell
-    - nakedret
-    - unconvert
     - bodyclose
     - dogsled
     - dupl
-    # - gosec
+    - misspell
+    - nakedret
     - nilerr
     - prealloc
-    # - revive
+    - unconvert
     - unparam
-    # - wrapcheck
-    # - gocritic
-linters-settings:
-  errcheck:
-    ignore: go.uber.org/zap:Sync
-  goimports:
-    # put imports beginning with prefix after 3rd-party packages;
-    # it's a comma-separated list of prefixes
-    local-prefixes: github.com/fission/fission,github.com/fission/keda-connectors
+  settings:
+    errcheck:
+      exclude-functions:
+        - (*go.uber.org/zap.Logger).Sync
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  settings:
+    goimports:
+      local-prefixes:
+        - github.com/fission/fission
+        - github.com/fission/keda-connectors
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
diff --git a/gcp-pubsub-http-connector/main.go b/gcp-pubsub-http-connector/main.go
@@ -188,6 +188,6 @@ func GetGCPInfo() (*GCPPubsubConnInfo, error) {
 		return connInfo, nil
 	}
 
-	return nil, errors.New("Provide credentials ")
+	return nil, errors.New("provide credentials")
 
 }
diff --git a/go.mod b/go.mod
@@ -1,6 +1,6 @@
 module github.com/fission/keda-connectors
 
-go 1.23.1
+go 1.24.3
 
 require (
 	cloud.google.com/go/pubsub v1.39.0
diff --git a/kafka-http-connector/scram_client.go b/kafka-http-connector/scram_client.go
@@ -25,11 +25,11 @@ type XDGSCRAMClient struct {
 }
 
 func (x *XDGSCRAMClient) Begin(userName, password, authzID string) (err error) {
-	x.Client, err = x.HashGeneratorFcn.NewClient(userName, password, authzID)
+	x.Client, err = x.NewClient(userName, password, authzID)
 	if err != nil {
 		return err
 	}
-	x.ClientConversation = x.Client.NewConversation()
+	x.ClientConversation = x.NewConversation()
 	return nil
 }
 
diff --git a/kafka-http-connector/test/kubernetes/kafka-cluster.yaml b/kafka-http-connector/test/kubernetes/kafka-cluster.yaml
@@ -1,11 +1,34 @@
 apiVersion: kafka.strimzi.io/v1beta2
+kind: KafkaNodePool
+metadata:
+  name: dual-role
+  labels:
+    strimzi.io/cluster: my-cluster-test
+spec:
+  replicas: 1
+  roles:
+    - controller
+    - broker
+  storage:
+    type: jbod
+    volumes:
+      - id: 0
+        type: persistent-claim
+        size: 20Gi
+        deleteClaim: false
+        kraftMetadata: shared
+---
+apiVersion: kafka.strimzi.io/v1beta2
 kind: Kafka
 metadata:
   name: my-cluster-test
-  namespace: kafka
+  annotations:
+    strimzi.io/node-pools: enabled
+    strimzi.io/kraft: enabled
 spec:
   kafka:
-    replicas: 1
+    version: 4.0.0
+    metadataVersion: 4.0-IV3
     listeners:
       - name: plain
         port: 9092
@@ -15,29 +38,16 @@ spec:
         port: 9093
         type: internal
         tls: true
-        authentication:
-          type: tls
       - name: external
         port: 9094
         type: nodeport
         tls: false
-    storage:
-      type: jbod
-      volumes:
-        - id: 0
-          type: persistent-claim
-          size: 20Gi
-          deleteClaim: false
     config:
       offsets.topic.replication.factor: 1
       transaction.state.log.replication.factor: 1
       transaction.state.log.min.isr: 1
-  zookeeper:
-    replicas: 1
-    storage:
-      type: persistent-claim
-      size: 20Gi
-      deleteClaim: false
+      default.replication.factor: 1
+      min.insync.replicas: 1
   entityOperator:
     topicOperator: {}
     userOperator: {}

Original file line number	Diff line number	Diff line change
`@@ -188,6 +188,6 @@ func GetGCPInfo() (*GCPPubsubConnInfo, error) {`
`188`	`188`	`return connInfo, nil`
`189`	`189`	`}`
`190`	`190`
`191`		`- return nil, errors.New("Provide credentials ")`
	`191`	`+ return nil, errors.New("provide credentials")`
`192`	`192`
`193`	`193`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,11 +25,11 @@ type XDGSCRAMClient struct {`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`func (x *XDGSCRAMClient) Begin(userName, password, authzID string) (err error) {`
`28`		`- x.Client, err = x.HashGeneratorFcn.NewClient(userName, password, authzID)`
	`28`	`+ x.Client, err = x.NewClient(userName, password, authzID)`
`29`	`29`	`if err != nil {`
`30`	`30`	`return err`
`31`	`31`	`}`
`32`		`- x.ClientConversation = x.Client.NewConversation()`
	`32`	`+ x.ClientConversation = x.NewConversation()`
`33`	`33`	`return nil`
`34`	`34`	`}`
`35`	`35`