Skip to content

Score inconsistency between the emails list and the email panel #74

@Flaburgan

Description

@Flaburgan

Describe the bug
I have an inconsistency between the SpamScore column in the e-mails list which displays a score of 607 and the button in the email visualisation which displays a score of 20.

Image Image

When I looked in the email header, I see that there are two scores provided:

Organization: OVHcloud
User-Agent: OVHcloud nces
X-Mailer: OVHcloud nces
X-Ovh-Nic: zi25062-ovh
X-Ovh-Notification-Id: [TOO LONG, REMOVED]
X-Ovh-Template: nic/de/newNicEmailValidationCode2020v1
X-Ovh-Tracer-Id: 11871770093883736351
X-VR-SPAMSTATE: ACCOUNT
X-VR-SPAMSCORE: 20
X-VR-SPAMCAUSE: [TOO LONG, REMOVED]
X-Ovh-Spam-Status: OK
X-Ovh-Spam-Reason: vr: ACCOUNT; dkim: disabled; spf: disabled
X-Ovh-Message-Type: ACCOUNT
Message-ID: <a8e60e9a-81da-4441-89bf-9b8e9a05f914@notification-center-email-sender>
X-OVH-Remote: 136.55.171.214 ([136.55.171.214])
X-VR-SPAMSTATE: PHISHING
X-VR-SPAMSCORE: 607
X-VR-SPAMCAUSE: dmFkZTFq0UdeaoNjrzVJDj[TOO LONG, REMOVED]
X-Ovh-Spam-Status: OK
X-Ovh-Spam-Reason: vr: ACCOUNT; dkim: disabled; spf: disabled
X-Ovh-Message-Type: ACCOUNT

So it looks like the addon is in one case stopping at the first X-VR-SPAMSCORE it is encountering, and in the second case at the last one. The same logic should be used in both places (I guess always the last one? in that case that is the correct score).

Idk why OVH is sending two X-VR-SPAMSCORE, but in that specific example, the e-mail definitely is a phishing tentative, so I would say that this addon could be a bit smarter and look for X-VR-SPAMSTATE and if it is PHISHING then this score should be the one chosen.

Thunderbird (please complete the following information):

  • OS: Linux Mint 21
  • Version: Thunderbird 128.12.0esr (64 bits)

Spam Score add-on (please complete the following information):

  • Version: 1.6.0

Thank you for your great work!

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions