parse tool profile once before validating tests

d-callan · d-callan · commit 324930d72bd1 · 2026-01-29T11:00:31.000-05:00
diff --git a/lib/galaxy/tool_util/verify/parse.py b/lib/galaxy/tool_util/verify/parse.py
@@ -135,6 +135,7 @@ def _description_from_tool_source(
 
     tool_id, tool_version = _tool_id_and_version(tool_source, tool_guid)
     processed_test_dict: Union[ValidToolTestDict, InvalidToolTestDict]
+    profile = tool_source.parse_profile()
     try:
         processed_inputs = _process_raw_inputs(
             tool_source,
@@ -144,7 +145,6 @@ def _description_from_tool_source(
             required_data_tables,
             required_loc_files,
         )
-        profile = tool_source.parse_profile()
         processed_test_dict = ValidToolTestDict(
             {
                 "inputs": processed_inputs,
@@ -172,7 +172,6 @@ def _description_from_tool_source(
             }
         )
     except Exception:
-        profile = tool_source.parse_profile()
         processed_test_dict = InvalidToolTestDict(
             {
                 "tool_id": tool_id,

Original file line number	Diff line number	Diff line change
`@@ -135,6 +135,7 @@ def _description_from_tool_source(`
`135`	`135`
`136`	`136`	`tool_id, tool_version = _tool_id_and_version(tool_source, tool_guid)`
`137`	`137`	`processed_test_dict: Union[ValidToolTestDict, InvalidToolTestDict]`
	`138`	`+ profile = tool_source.parse_profile()`
`138`	`139`	`try:`
`139`	`140`	`processed_inputs = _process_raw_inputs(`
`140`	`141`	`tool_source,`
`@@ -144,7 +145,6 @@ def _description_from_tool_source(`
`144`	`145`	`required_data_tables,`
`145`	`146`	`required_loc_files,`
`146`	`147`	`)`
`147`		`- profile = tool_source.parse_profile()`
`148`	`148`	`processed_test_dict = ValidToolTestDict(`
`149`	`149`	`{`
`150`	`150`	`"inputs": processed_inputs,`
`@@ -172,7 +172,6 @@ def _description_from_tool_source(`
`172`	`172`	`}`
`173`	`173`	`)`
`174`	`174`	`except Exception:`
`175`		`- profile = tool_source.parse_profile()`
`176`	`175`	`processed_test_dict = InvalidToolTestDict(`
`177`	`176`	`{`
`178`	`177`	`"tool_id": tool_id,`