Missing DLLs on windows image makes editor not execute

[leo14s]

Bug description

My CI runs started to fail with an exit code 3221225781 right after the image tags were updated on Docker Hub for "old" editor unity versions. like 2021.3.45f2

Investigating, it is related to missing DLLs. I found this PR, which removes two DLLs #256

I fixed it locally by adding the DLLs back to the image on my Dockerfile, copying from my own machine.

How to reproduce

• Clone unityci/editor:windows-2021.3.45f2-base-3
• Run a container with -it
• Go to unity executable and test it with Unity.exe -version
• See that no logs are printed nor saved anywhere

Expected behavior

Unity editor executes

Additional details

[riemaeker]

We have the same issue using an older (2021.3.28f1) image starting from 3.2.0: Unity just won't start. Our fix is to add the DLL's to our pre-Unity 6 images:

ARG UNITY_VERSION
ARG TARGET_PLATFORM

FROM unityci/editor:windows-${UNITY_VERSION}-${TARGET_PLATFORM}-3.2.1

ARG UNITY_VERSION

# Copy missing DLL's into the image.
COPY ./MSVCP120.dll ./MSVCR120.dll C:/Temp/

# Copy to System32 for Unity 20xx versions.
RUN if ($env:UNITY_VERSION -match '^2') { \
  Copy-Item C:/Temp/MSVCP120.dll, C:/Temp/MSVCR120.dll -Destination C:/Windows/System32/ \
}