#5234 Fix spaces in createAnnotatioh() function link text

Author: stroomdev66

stroom-core-client-widget/src/main/java/stroom/hyperlink/client/Hyperlink.java

@@ -80,7 +80,7 @@ public static Hyperlink create(final String value, final int pos) {
                     }
                     final String target = nextToken(value, index, '<', '>');
                     hyperlink = new Builder()
-                            .text(text)
+                            .text(decode(text))
                             .href(decode(href))
                             .type(type)
                             .target(target)
@@ -125,20 +125,9 @@ private static String nextToken(final String value,
         return null;
     }
 
-//    private static void throwException(final String value,
-//                                       final int pos,
-//                                       final char startChar,
-//                                       final char endChar) throws MalformedLinkException {
-//        throw new MalformedLinkException("Invalid required token in value '" + value
-//                                         + "', pos: " + pos
-//                                         + ", startChar: '" + startChar
-//                                         + "' endChar: '" + endChar + "'");
-//    }
-
     public String getText() {
         // Why are we decoding the plain text part?
         return text;
-//        return text;
     }
 
     public String getHref() {
@@ -213,7 +202,7 @@ public String toString() {
         final StringBuilder sb = new StringBuilder();
         if (text != null) {
             sb.append("[");
-            sb.append(text);
+            sb.append(encode(text));
             sb.append("]");
         }
         if (href != null) {

unreleased_changes/20260128_154859_690__5234.md

@@ -0,0 +1,68 @@
+* Bug **#5234** : Fix spaces in `createAnnotatioh()` function link text.
+
+
+```sh
+# ********************************************************************************
+# Issue number: 5234
+# Issue title:  createAnnotation()  converts spaces to `+` for the text parameter
+# Issue tags:   f:Annotations, p:high
+# Issue link:   https://github.com/gchq/stroom/issues/5234
+# ********************************************************************************
+
+# ONLY the top line will be included as a change entry in the CHANGELOG.
+# The entry should be in GitHub flavour markdown and should be written on a SINGLE
+# line with no hard breaks. You can have multiple change files for a single GitHub issue.
+# The  entry should be written in the imperative mood, i.e. 'Fix nasty bug' rather than
+# 'Fixed nasty bug'.
+#
+# Examples of acceptable entries are:
+#
+#
+# * Bug **#123** : Fix bug with an associated GitHub issue in this repository.
+#
+# * Bug **namespace/other-repo#456** : Fix bug with an associated GitHub issue in another repository.
+#
+# * Feature **#789** : Add new feature X.
+#
+# * Bug : Fix bug with no associated GitHub issue.
+#
+#
+# Note: The line must start '* XXX ', where 'XXX' is a valid category,
+#       one of [Bug Feature Refactor Dependency Build].
+
+
+# --------------------------------------------------------------------------------
+# The following is random text to make this file unique for git's change detection
+# HUEdjqogF0mcjLfAZjwJrsLO4y8m81ARhUrdJfhLwTAbVjKCRyijR6FE5ZNQHfstllHB253FwBRakRYD
+# dqYrxmrH8NAsIIYymuztsQ9f62rnT3BNgNmGFd2BYGEYjt7YyUmGu0Eg1VUuln7x6d2HM6rC7j19gk74
+# VmH4xN8YzPDsx38fL7uUb8jjoFTJx05C5sUx7NZZpNn3RGFJR96aY5fCpI32yEmKxKTgqfZ6hdg99kHT
+# JluLCE6dDa9lrojss2Bnn1KDU1nwTEIflK3QxUZfc1sRr2OU5KVjxmGELCN2N9rdZFDKCfoKxZVLzMXB
+# sqAhSWj2NJPzAfTzMgtaKdH6GSnhPMhZyQ2P2zY5YLoMzdXzZKqxGkQLDFKInsfPgtIENTigoHXCkVtr
+# sZcSl1dubUwnPYpdfE4tjgMT5JabElLqBi3jM0oDJNNYToVAa6RWsMMIOMp5cPzzkXxtXI4UGIwqKJYH
+# 49X3vMvijMosMnz7G0fcjI6WDalBAhubFgmoT6sxFMiChazWc3akjZVZvfbcdo4ITP5GaK4m0zMiaQSh
+# jVy0ZfnNB3sPXDx79AiSYbkCKRaKESyTYvHrwoKjAgLlTYOQ5kTXAqEeaVhBManEigdjTYHQmWind6xK
+# rz9qkr8ahs7r9pxQ9RGavfzIvP8UdACx4bRawXlXanWhyJ7OHOVe5afma0Jxd4gbpIkAy1UP2ts0y6AQ
+# 8X5ja8vkTZEoBhO1Kz5NLtZg4cjIba7S5yQpvSTbai51RkC6WLtCfAk4GnpblO0e5grcTpLNNWCwLIGH
+# ShqXLnwK6eAqd5D4ulzgsykCBu51CwBKELIil9ep0xsz68WFxWEqFCVmbSpBsC6sSdfTyYvbnO1jYv28
+# jp0ml4vhZcnnpqQXHBwHD75vMm7PS0hNw7XGLorpvyhlq9UYU8SpnCnbhQy5OecyiZHWLEfgH1k8z7st
+# K2LruexbH5kTVBLlOMbi6p7oZxFsw3J85HN9oK63Uk96zTFG6wO9ErjJbPeZMHCO2cn2eOAf5Lmlv8Oi
+# H9cQ5fGk1Z9ZJGDVNZHxN2PAbM5QiX2U4lZ4gc9GpddyIAUbOX8Co3Bg9aAj6fzNBO5GE8PPw9ADgwCn
+# cpBh47QHnj4pRnEUdQv0G3Uiu64mjcI0HQ8GykbjEpOw5g1g3Q6OvY762IXoNoSItAXdUWe78XGauJVO
+# OTu5ORbgk1VqpU01Ts7Hjwr0HXPYK9Pwrazs2MSErgbrAKfAMIyKTMqu3suwyINbcIduWn6kbTYZ2hcf
+# yxudTnsKug6pC3LokkBFNSw5vGYb6QutLyKzHGIrGgDpYx3wPNrzDvYIKos07ux0N6xNofpou6izVlml
+# xV3ClFzvEI02lscFsMbE8GyiQeOCdYsSeijZzqXDtLp5I9PUYe10tfgOjkDLzYvKHDMXsRfVfGp47PKL
+# pbPpLpTRp38lEXHyhsSoDJAmviF3xVnOqqgaqhbPhy5QsQb6vEQXUuBbozgjmcaMSSerK49QTs3Wg9fw
+# TyShhZeNMA5Nwqnr0b5stveuzzadBiOhYrLYEUQz2tIUEy8D1DnmcgKwsZzoXNFjA568sgBROOuNk8hq
+# uVnO4jCBpFVYZVxQ0fnyVc4AI4rHNrFRMIK80fOZWwH6pIDlMmUMNwl3lEqyEaxD4MpWKpuzqXoyTAus
+# kxZxFScVgz4OnxNYRDfN2LcyCinvQ7xeRPfbuhDlaGqKppC8uOgFTqzrZPMg9DcuXJsfOZBqGu4UTtiq
+# 7nh9zTTXYWuyXf1AmroFE91c11ZZ4P31wqqSWmvee871vE335OhL9KsoNcgGwzjZvtLwma5QVP0xsQ7A
+# KLgnZHjSpm5my4MxXVkAwzdeW7sEuoU0ujIERHEymjn1kJA10VxW3YUdMRvhRpTvw6ijumEFGcqjfFje
+# 8o5JpkGEDxPVy5mC4YhUdYSLPn7GCZdh42rQQUDIsL6LoyJGe4YD6x1gFJRiJMM8VJHbqf0GhnjLQv4n
+# 73g5OO7APIDsG7f9PgyCPRgrUcnu7EaOYkZjHl3G3Hpu8U65qzikpJPEyMlMtZGp5V5CSZdvTO8koXoF
+# k3HEGxGBIbrsrsfj3OGtPbV1pj0cxT2b0DVEwIkgUPko73YQRkmTFA6b6cj1sIE0XKAzB7VtSBz4M4ca
+# IDUVQWGr84CBm6jPAxJiTtDGvlOVZll7kCrziMOpsYqgPbR52qrwXv6wOHpQoIBgpM5ukAmOH3Mw4GVV
+# aCjgmrY2X2mwXC3uPUb4ZPG4EFwYFhUZJYzmgFPIvevCaghX0taeyzbSuCcedrP0u88JCBDTrUEtMPzM
+# Jy2dS9RJMQcsozEz8S6H5x7jInkX62ptLIKKFhZEUBIPboq6KLg7UZGHQuwR1cNS4cxPgIzcl9Z8sGCY
+# --------------------------------------------------------------------------------
+
+```