fix: tests

Author: muhammad.fahlevi

Makefile

@@ -92,3 +92,6 @@ test-coverage: # test test-plugins
 	cp coverage.out coverage-all.out
 	tail -n +2 coverage-plugins.out >> coverage-all.out
 	go tool cover -html=coverage-all.out
+
+test-all: test test-plugins test-e2e ##@tests run all tests
+	@echo " > All tests passed!"

plugins/extractors/bigquery/testdata/expected-assets-mixed.json

@@ -153,6 +153,7 @@
         }
       ],
       "create_time": "2023-06-13T03:46:12.372974Z",
+      "ddl_statement": "",
       "preview_fields": [
         "id",
         "name",

plugins/extractors/bigquery/testdata/expected-assets-no-preview.json

@@ -153,6 +153,7 @@
                 }
             ],
             "create_time": "2023-06-13T03:46:12.372974Z",
+            "ddl_statement": "",
             "preview_fields": [],
             "preview_rows": null,
             "profile": {

plugins/extractors/bigquery/testdata/expected-assets.json

@@ -153,6 +153,7 @@
                 }
             ],
             "create_time": "2023-06-13T03:46:12.372974Z",
+            "ddl_statement": "",
             "preview_fields": [
                 "id",
                 "name",

plugins/extractors/bigtable/testdata/expected-assets.json

@@ -8,6 +8,7 @@
             },
             "columns": [],
             "create_time": null,
+            "ddl_statement": "",
             "preview_fields": [],
             "preview_rows": null,
             "profile": null,

plugins/extractors/redshift/testdata/expected-assets.json

@@ -17,6 +17,7 @@
                 }
             ],
             "create_time": null,
+            "ddl_statement": "",
             "preview_fields": [],
             "preview_rows": null,
             "profile": null,
@@ -54,6 +55,7 @@
                 }
             ],
             "create_time": null,
+            "ddl_statement": "",
             "preview_fields": [],
             "preview_rows": null,
             "profile": null,
@@ -91,6 +93,7 @@
                 }
             ],
             "create_time": null,
+            "ddl_statement": "",
             "preview_fields": [],
             "preview_rows": null,
             "profile": null,
@@ -128,6 +131,7 @@
                 }
             ],
             "create_time": null,
+            "ddl_statement": "",
             "preview_fields": [],
             "preview_rows": null,
             "profile": null,

plugins/sinks/compass/sink_test.go

@@ -194,11 +194,11 @@ func TestSink(t *testing.T) {
 		{
 			description: "should create the right request to compass",
 			data: &v1beta2.Asset{
-				Urn:         "my-topic-urn",
-				Name:        "my-topic",
-				Service:     "kafka",
-				Type:        "topic",
-				Description: "topic information",
+				Urn:         "my-table-urn",
+				Name:        "my-table",
+				Service:     "maxcompute",
+				Type:        "table",
+				Description: "table information",
 				Url:         "http://test.com",
 				Data: testutils.BuildAny(t, &v1beta2.Table{
 					Columns: []*v1beta2.Column{
@@ -221,12 +221,12 @@ func TestSink(t *testing.T) {
 			},
 			expected: compass.RequestPayload{
 				Asset: compass.Asset{
-					URN:         "my-topic-urn",
-					Name:        "my-topic",
-					Service:     "kafka",
-					Type:        "topic",
+					URN:         "my-table-urn",
+					Name:        "my-table",
+					Service:     "maxcompute",
+					Type:        "table",
 					URL:         "http://test.com",
-					Description: "topic information",
+					Description: "table information",
 					Data: map[string]interface{}{
 						"@type": "type.googleapis.com/gotocompany.assets.v1beta2.Table",
 						"columns": []map[string]interface{}{
@@ -242,6 +242,7 @@ func TestSink(t *testing.T) {
 							},
 						},
 						"create_time":    nil,
+						"ddl_statement":  "",
 						"preview_fields": []interface{}{},
 						"preview_rows":   nil,
 						"profile":        nil,
@@ -258,11 +259,11 @@ func TestSink(t *testing.T) {
 		{
 			description: "should build compass labels if labels is defined in config",
 			data: &v1beta2.Asset{
-				Urn:         "my-topic-urn",
-				Name:        "my-topic",
-				Service:     "kafka",
-				Type:        "topic",
-				Description: "topic information",
+				Urn:         "my-table-urn",
+				Name:        "my-table",
+				Service:     "maxcompute",
+				Type:        "table",
+				Description: "table information",
 				Data: testutils.BuildAny(t, &v1beta2.Table{
 					Attributes: utils.TryParseMapToProto(map[string]interface{}{
 						"attrA": "valueAttrA",
@@ -279,11 +280,12 @@ func TestSink(t *testing.T) {
 			},
 			expected: compass.RequestPayload{
 				Asset: compass.Asset{
-					URN:         "my-topic-urn",
-					Name:        "my-topic",
-					Service:     "kafka",
-					Type:        "topic",
-					Description: "topic information",
+					URN:         "my-table-urn",
+					Name:        "my-table",
+					Service:     "maxcompute",
+					Type:        "table",
+					URL:         "http://test.com",
+					Description: "table information",
 					Labels: map[string]string{
 						"foo": "valueAttrA",
 						"bar": "valueAttrB",
@@ -296,6 +298,7 @@ func TestSink(t *testing.T) {
 						},
 						"columns":        []interface{}{},
 						"create_time":    nil,
+						"ddl_statement":  "",
 						"preview_fields": []interface{}{},
 						"preview_rows":   nil,
 						"profile":        nil,
@@ -307,10 +310,10 @@ func TestSink(t *testing.T) {
 		{
 			description: "should merge labels from assets and config",
 			data: &v1beta2.Asset{
-				Urn:     "my-topic-urn",
-				Name:    "my-topic",
-				Service: "kafka",
-				Type:    "topic",
+				Urn:     "my-table-urn",
+				Name:    "my-table",
+				Service: "maxcompute",
+				Type:    "table",
 				Data: testutils.BuildAny(t, &v1beta2.Table{
 					Attributes: utils.TryParseMapToProto(map[string]interface{}{
 						"newFoo": "newBar",
@@ -329,10 +332,10 @@ func TestSink(t *testing.T) {
 			},
 			expected: compass.RequestPayload{
 				Asset: compass.Asset{
-					URN:     "my-topic-urn",
-					Name:    "my-topic",
-					Service: "kafka",
-					Type:    "topic",
+					URN:     "my-table-urn",
+					Name:    "my-table",
+					Service: "maxcompute",
+					Type:    "table",
 					Labels: map[string]string{
 						"foo1": "bar1",
 						"foo2": "newBar",
@@ -344,6 +347,7 @@ func TestSink(t *testing.T) {
 						},
 						"columns":        []interface{}{},
 						"create_time":    nil,
+						"ddl_statement":  "",
 						"preview_fields": []interface{}{},
 						"preview_rows":   nil,
 						"profile":        nil,

plugins/sinks/file/test-dir/sample.ndjson

@@ -1,2 +1,2 @@
-{"urn":"elasticsearch.index1","name":"index1","service":"","type":"table","url":"","description":"","data":{"@type":"type.googleapis.com/gotocompany.assets.v1beta2.Table","profile":{"total_rows":"1","partition_key":"","partition_value":"","usage_count":"0","common_joins":[],"filters":[]},"columns":[{"name":"SomeStr","description":"","data_type":"text","is_nullable":false,"length":"0","profile":null,"columns":[],"attributes":null}],"preview_fields":[],"preview_rows":null,"attributes":null,"create_time":null,"update_time":null},"owners":[],"lineage":null,"labels":{},"is_deleted":false,"event":null,"create_time":null,"update_time":null,"refreshed_at":null}
-{"urn":"elasticsearch.index2","name":"index2","service":"","type":"table","url":"","description":"","data":{"@type":"type.googleapis.com/gotocompany.assets.v1beta2.Table","profile":{"total_rows":"1","partition_key":"","partition_value":"","usage_count":"0","common_joins":[],"filters":[]},"columns":[{"name":"SomeStr","description":"","data_type":"text","is_nullable":false,"length":"0","profile":null,"columns":[],"attributes":null}],"preview_fields":[],"preview_rows":null,"attributes":null,"create_time":null,"update_time":null},"owners":[],"lineage":null,"labels":{},"is_deleted":false,"event":null,"create_time":null,"update_time":null,"refreshed_at":null}
+{"urn":"elasticsearch.index1","name":"index1","service":"","type":"table","url":"","description":"","data":{"@type":"type.googleapis.com/gotocompany.assets.v1beta2.Table","profile":{"total_rows":"1","partition_key":"","partition_value":"","usage_count":"0","common_joins":[],"filters":[]},"columns":[{"name":"SomeStr","description":"","data_type":"text","is_nullable":false,"length":"0","profile":null,"columns":[],"attributes":null}],"preview_fields":[],"preview_rows":null,"ddl_statement":"","attributes":null,"create_time":null,"update_time":null},"owners":[],"lineage":null,"labels":{},"is_deleted":false,"event":null,"create_time":null,"update_time":null,"refreshed_at":null}
+{"urn":"elasticsearch.index2","name":"index2","service":"","type":"table","url":"","description":"","data":{"@type":"type.googleapis.com/gotocompany.assets.v1beta2.Table","profile":{"total_rows":"1","partition_key":"","partition_value":"","usage_count":"0","common_joins":[],"filters":[]},"columns":[{"name":"SomeStr","description":"","data_type":"text","is_nullable":false,"length":"0","profile":null,"columns":[],"attributes":null}],"preview_fields":[],"preview_rows":null,"ddl_statement":"","attributes":null,"create_time":null,"update_time":null},"owners":[],"lineage":null,"labels":{},"is_deleted":false,"event":null,"create_time":null,"update_time":null,"refreshed_at":null}