Fixup two search dialog bugs (#564)

Author: jonko0493

src/SerialLoops.Lib/Project.cs

@@ -1607,6 +1607,17 @@ private bool ItemIsInEpisode(ItemDescription item, int episodeNum, bool unique)
     }
 
     private bool ScriptIsInEpisode(ScriptItem script, int scenarioEpIndex, int scenarioNextEpIndex)
+    {
+        int scriptFileScenarioIndex = GetScriptScenarioIndex(script);
+        if (scenarioNextEpIndex < 0)
+        {
+            scenarioNextEpIndex = int.MaxValue;
+        }
+
+        return scriptFileScenarioIndex > scenarioEpIndex && scriptFileScenarioIndex < scenarioNextEpIndex;
+    }
+
+    private int GetScriptScenarioIndex(ScriptItem script)
     {
         int scriptFileScenarioIndex = Scenario.Commands.FindIndex(c => c.Verb == ScenarioCommand.ScenarioVerb.LOAD_SCENE && c.Parameter == script.Event.Index);
         if (scriptFileScenarioIndex < 0)
@@ -1617,13 +1628,14 @@ private bool ScriptIsInEpisode(ScriptItem script, int scenarioEpIndex, int scena
             {
                 scriptFileScenarioIndex = Scenario.Commands.FindIndex(c => c.Verb == ScenarioCommand.ScenarioVerb.ROUTE_SELECT && c.Parameter == ((GroupSelectionItem)groupSelection).Index);
             }
-        }
-        if (scenarioNextEpIndex < 0)
-        {
-            scenarioNextEpIndex = int.MaxValue;
+            ItemDescription otherScript = references.Find(r => r.Type == ItemType.Script);
+            if (otherScript is not null)
+            {
+                scriptFileScenarioIndex = GetScriptScenarioIndex((ScriptItem)otherScript);
+            }
         }
 
-        return scriptFileScenarioIndex > scenarioEpIndex && scriptFileScenarioIndex < scenarioNextEpIndex;
+        return scriptFileScenarioIndex;
     }
 
     [GeneratedRegex(@"\((?<num>\d+)\)")]

src/SerialLoops/Assets/Strings.Designer.cs

@@ -3336,4 +3336,13 @@ item in the dropdown!</value>
   <data name="PuzzleEditorUnknown04" xml:space="preserve">
     <value>Unknown 04</value>
   </data>
+  <data name="Title" xml:space="preserve">
+    <value>Title</value><comment>Search scope</comment>
+  </data>
+  <data name="Flag" xml:space="preserve">
+    <value>Flag</value><comment>Search scope</comment>
+  </data>
+  <data name="Conditional" xml:space="preserve">
+    <value>Search scope</value>
+  </data>
 </root>

src/SerialLoops/Assets/Strings.resx

@@ -201,7 +201,7 @@ public class LocalizedItemScope(ItemDescription.ItemType type) : ReactiveObject
 {
     public ItemDescription.ItemType Type { get; } = type;
     public string Icon => $"avares://SerialLoops/Assets/Icons/{Type.ToString()}.svg";
-    public string DisplayText { get; } = Strings.ResourceManager.GetString($"{type.ToString()}s");
+    public string DisplayText { get; } = Strings.ResourceManager.GetString($"ItemsPanel{type.ToString().Replace("_", "")}s");
     [Reactive]
     public bool IsActive { get; set; } = true;
 }