Run stack tests sequentially on windows

Author: alexfmpe

tests/BiosTests.hs

@@ -18,6 +18,7 @@ import HIE.Bios.Cradle
 import Control.Monad (forM_)
 import Control.Monad.Extra (unlessM)
 import Control.Monad.IO.Class
+import Data.Bool (bool)
 import Data.Foldable (for_)
 import Data.List ( sort, isPrefixOf )
 import Data.Typeable
@@ -64,15 +65,18 @@ main = do
   cabalDep <- checkToolIsAvailable "cabal"
   extraGhcDep <- checkToolIsAvailable extraGhc
 
+  -- There seems to be a race condition on stack tests on windows
+  let stackTestGroup = bool testGroup (`sequentialTestGroup` AllFinish) isWindows
+
   defaultMainWithIngredients (ignoreToolTests:verboseLogging:defaultIngredients) $
     testGroup "Bios-tests"
       [ testGroup "Find cradle" findCradleTests
       , testGroup "Symlink" symbolicLinkTests
       , testGroup "Loading tests"
         [ testGroup "bios" biosTestCases
         , testGroup "direct" directTestCases
-        , testGroupWithDependency cabalDep (cabalTestCases extraGhcDep)
-        , ignoreOnUnsupportedGhc $ testGroupWithDependency stackDep stackTestCases
+        , withDependency testGroup cabalDep (cabalTestCases extraGhcDep)
+        , ignoreOnUnsupportedGhc $ withDependency stackTestGroup stackDep stackTestCases
         ]
       ]
 
@@ -259,7 +263,7 @@ cabalTestCases extraGhcDep =
       , biosTestCase "implicit-cabal-deep-project" $ runTestEnv "./implicit-cabal-deep-project" $ do
           testImplicitDirectoryM isCabalCradle "foo/Main.hs"
       ]
-  , testGroupWithDependency extraGhcDep
+  , withDependency testGroup extraGhcDep
     [ biosTestCase "Appropriate ghc and libdir" $ runTestEnvLocal "./cabal-with-ghc" $ do
         initCradle "src/MyLib.hs"
         assertCradle isCabalCradle
@@ -292,7 +296,7 @@ cabalTestCases extraGhcDep =
     , biosTestCase "multi-cabal-with-project, load" $ runTestEnv "multi-cabal-with-project" $ do
         testDirectoryM isCabalCradle "appB/src/Lib.hs"
         testDirectoryM isCabalCradle "appB/src/Lib.hs"
-    , testGroupWithDependency extraGhcDep
+    , withDependency testGroup extraGhcDep
       [ biosTestCase "Honours extra ghc setting" $ runTestEnv "cabal-with-ghc-and-project" $ do
           initCradle "src/MyLib.hs"
           assertCradle isCabalCradle
@@ -503,14 +507,14 @@ checkToolIsAvailable f = do
     , toolExists = exists
     }
 
-testGroupWithDependency :: ToolDependency -> [TestTree] -> TestTree
-testGroupWithDependency td tc = askOption @IgnoreToolDeps (\case
+withDependency :: (TestName -> [TestTree] -> TestTree) -> ToolDependency -> [TestTree] -> TestTree
+withDependency group td tc = askOption @IgnoreToolDeps (\case
   IgnoreToolDeps ignoreToolDep
     | ignoreToolDep || toolExists td -> tg
     | otherwise -> itg
   )
   where
-    tg = testGroup (toolName td) tc
+    tg = group (toolName td) tc
 
     itg =
       ignoreTestBecause