feat: support disabling docker legacy service links creation in keda containers (#725)

* Disable docker legacy service links

Signed-off-by: Gabi Davar <grizzly.nyo@gmail.com>

* switch default to true

Signed-off-by: Gabi Davar <grizzly.nyo@gmail.com>

---------

Signed-off-by: Gabi Davar <grizzly.nyo@gmail.com>

Author: mindw

keda/templates/manager/deployment.yaml

@@ -45,6 +45,7 @@ spec:
         {{- end }}
       {{- end }}
     spec:
+      enableServiceLinks: {{ .Values.enableServiceLinks }}
       {{- if .Values.priorityClassName }}
       priorityClassName: {{ .Values.priorityClassName | quote }}
       {{- end }}

keda/templates/metrics-server/deployment.yaml

@@ -44,6 +44,7 @@ spec:
         {{- end }}
       {{- end }}
     spec:
+      enableServiceLinks: {{ .Values.enableServiceLinks }}
       {{- if .Values.priorityClassName }}
       priorityClassName: {{ .Values.priorityClassName | quote }}
       {{- end }}

keda/templates/webhooks/deployment.yaml

@@ -43,6 +43,7 @@ spec:
         {{- end }}
       {{- end }}
     spec:
+      enableServiceLinks: {{ .Values.enableServiceLinks }}
       {{- if .Values.priorityClassName }}
       priorityClassName: {{ .Values.priorityClassName | quote }}
       {{- end }}

keda/values.yaml

@@ -863,3 +863,7 @@ asciiArt: true
 
 # -- When specified, each rendered resource will have `app.kubernetes.io/managed-by: ${this}` label on it. Useful, when using only helm template with some other solution.
 customManagedBy: ""
+
+# -- Enable service links in pods. Although enabled, mirroring k8s default, it is highly recommended to disable,
+# due to its legacy status [Legacy container links](https://docs.docker.com/engine/network/links/)
+enableServiceLinks: true