Skip to content

Commit 72410ec

Browse files
fix(http-add-on): allow specifying appProtocol for interceptor proxy service (#798)
Signed-off-by: Starlight Romero <[email protected]>
1 parent ced24e0 commit 72410ec

File tree

4 files changed

+11
-0
lines changed

4 files changed

+11
-0
lines changed

.github/workflows/ci-http-add-on.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,8 @@ jobs:
121121
interceptor:
122122
replicas:
123123
min: 1
124+
proxy:
125+
appProtocol: ""
124126
EOF
125127
126128
- name: Template Helm chart

http-add-on/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,7 @@ their default values.
177177
| `interceptor.pdb.maxUnavailable` | int | `1` | The maximum number of replicas that can be unavailable for the interceptor |
178178
| `interceptor.pdb.minAvailable` | int | `0` | The minimum number of replicas that should be available for the interceptor |
179179
| `interceptor.podAnnotations` | object | `{}` | Annotations to be added to the interceptor pods |
180+
| `interceptor.proxy.appProtocol` | string | `""` | The appProtocol for the interceptor's proxy service ports |
180181
| `interceptor.proxy.port` | int | `8080` | The port on which the interceptor's proxy service will listen for live HTTP traffic |
181182
| `interceptor.proxy.service` | string | `"interceptor-proxy"` | The name of the Kubernetes `Service` for the interceptor's proxy service. This is the service that accepts live HTTP traffic. |
182183
| `interceptor.pullPolicy` | string | `"Always"` | The image pull policy for the interceptor component |

http-add-on/templates/interceptor/service-proxy.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,16 @@ spec:
1212
- name: proxy
1313
port: {{ default 9091 .Values.interceptor.proxy.port }}
1414
targetPort: proxy
15+
{{- if .Values.interceptor.proxy.appProtocol }}
16+
appProtocol: {{ .Values.interceptor.proxy.appProtocol }}
17+
{{- end }}
1518
{{- if .Values.interceptor.tls.enabled }}
1619
- name: proxy-tls
1720
port: {{ default 8443 .Values.interceptor.tls.port }}
1821
targetPort: proxy-tls
22+
{{- if .Values.interceptor.proxy.appProtocol }}
23+
appProtocol: {{ .Values.interceptor.proxy.appProtocol }}
24+
{{- end }}
1925
{{- end }}
2026
selector:
2127
app.kubernetes.io/component: interceptor

http-add-on/values.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,8 @@ interceptor:
153153
service: interceptor-proxy
154154
# -- The port on which the interceptor's proxy service will listen for live HTTP traffic
155155
port: 8080
156+
# -- The appProtocol for the interceptor's proxy service ports
157+
appProtocol: ""
156158
replicas:
157159
# -- The minimum number of interceptor replicas that should ever be running
158160
min: 3

0 commit comments

Comments
 (0)