Patches for 0.5.1 release (#352)

* handled potential nil dereference (#349)

* Automated cherry pick of #347: Removed update operation from pod webhook (#348)

* removed update operation from webhook

* added to helm chart

* removed restarting group log (#350)

Author: Edwinhr716

charts/lws/templates/webhook/webhook.yaml

@@ -43,7 +43,6 @@ webhooks:
           - v1
         operations:
           - CREATE
-          - UPDATE
         resources:
           - pods
     sideEffects: None

config/webhook/manifests.yaml

@@ -40,7 +40,6 @@ webhooks:
     - v1
     operations:
     - CREATE
-    - UPDATE
     resources:
     - pods
   sideEffects: None

pkg/controllers/pod_controller.go

@@ -21,6 +21,7 @@ import (
 	"errors"
 	"fmt"
 	"strconv"
+	"time"
 
 	appsv1 "k8s.io/api/apps/v1"
 	corev1 "k8s.io/api/core/v1"
@@ -89,7 +90,6 @@ func (r *PodReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.R
 		return ctrl.Result{}, err
 	}
 	if leaderDeleted {
-		log.V(2).Info("restarting the group")
 		return ctrl.Result{}, nil
 	}
 
@@ -127,6 +127,10 @@ func (r *PodReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.R
 		log.Error(err, "Getting lws revisions")
 		return ctrl.Result{}, err
 	}
+	if revision == nil {
+		log.V(2).Info("Revision has not been created yet, requeing reconciler for pod %s", pod.Name)
+		return ctrl.Result{Requeue: true, RequeueAfter: time.Second}, nil
+	}
 	statefulSet, err := constructWorkerStatefulSetApplyConfiguration(pod, leaderWorkerSet, revision)
 	if err != nil {
 		return ctrl.Result{}, err

pkg/webhooks/pod_webhook.go

@@ -77,7 +77,7 @@ func (p *PodWebhook) ValidateDelete(ctx context.Context, obj runtime.Object) (ad
 	return nil, nil
 }
 
-//+kubebuilder:webhook:path=/mutate--v1-pod,mutating=true,failurePolicy=fail,groups="",resources=pods,verbs=create;update,versions=v1,name=mpod.kb.io,sideEffects=None,admissionReviewVersions=v1
+//+kubebuilder:webhook:path=/mutate--v1-pod,mutating=true,failurePolicy=fail,groups="",resources=pods,verbs=create,versions=v1,name=mpod.kb.io,sideEffects=None,admissionReviewVersions=v1
 
 func (p *PodWebhook) Default(ctx context.Context, obj runtime.Object) error {
 	log := logf.FromContext(ctx)